From be07262dc28c952022281443b341cb169aecf025 Mon Sep 17 00:00:00 2001 From: Yee Hing Tong Date: Tue, 16 Jan 2024 11:14:03 -0800 Subject: [PATCH 1/2] update instructions Signed-off-by: Yee Hing Tong --- docs/deployment/plugins/webapi/databricks.rst | 11 +++++------ docs/deployment/plugins/webapi/snowflake.rst | 11 +++++------ 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/docs/deployment/plugins/webapi/databricks.rst b/docs/deployment/plugins/webapi/databricks.rst index 671fdb4e18..a63522547e 100644 --- a/docs/deployment/plugins/webapi/databricks.rst +++ b/docs/deployment/plugins/webapi/databricks.rst @@ -288,7 +288,7 @@ Add the Databricks access token to FlytePropeller: .. group-tab:: Helm chart - Create an external secret as follows: + Create a secret as follows (or add to it if it already exists from other plugins): .. code-block:: bash @@ -296,7 +296,7 @@ Add the Databricks access token to FlytePropeller: apiVersion: v1 kind: Secret metadata: - name: flyte-binary-client-secrets-external-secret + name: flyte-binary-external-services namespace: flyte type: Opaque stringData: @@ -304,16 +304,15 @@ Add the Databricks access token to FlytePropeller: EOF Reference the newly created secret in - ``.Values.configuration.auth.clientSecretsExternalSecretRef`` + ``.Values.configuration.inlineSecretRef`` in your YAML file as follows: .. code-block:: yaml :emphasize-lines: 3 configuration: - auth: - clientSecretsExternalSecretRef: flyte-binary-client-secrets-external-secret - + inlineSecretRef: flyte-binary-external-services + Replace ```` with your access token. .. group-tab:: Flyte core diff --git a/docs/deployment/plugins/webapi/snowflake.rst b/docs/deployment/plugins/webapi/snowflake.rst index 85f13fe115..01376c499c 100644 --- a/docs/deployment/plugins/webapi/snowflake.rst +++ b/docs/deployment/plugins/webapi/snowflake.rst @@ -154,7 +154,7 @@ Then, add the Snowflake JWT token to FlytePropeller. .. group-tab:: Helm chart - Create an external secret as follows: + Create a secret as follows (or add to it if it already exists from other plugins): .. code-block:: bash @@ -162,7 +162,7 @@ Then, add the Snowflake JWT token to FlytePropeller. apiVersion: v1 kind: Secret metadata: - name: flyte-binary-client-secrets-external-secret + name: flyte-binary-external-services namespace: flyte type: Opaque stringData: @@ -170,16 +170,15 @@ Then, add the Snowflake JWT token to FlytePropeller. EOF Reference the newly created secret in - ``.Values.configuration.auth.clientSecretsExternalSecretRef`` + ``.Values.configuration.inlineSecretRef`` in your YAML file as follows: .. code-block:: yaml :emphasize-lines: 3 configuration: - auth: - clientSecretsExternalSecretRef: flyte-binary-client-secrets-external-secret - + inlineSecretRef: flyte-binary-external-services + Replace ```` with your JWT token. .. group-tab:: Flyte core From de1cf439322cf45a979e8c2d1e8fd6fe8e3b6ab7 Mon Sep 17 00:00:00 2001 From: Yee Hing Tong Date: Tue, 16 Jan 2024 11:25:50 -0800 Subject: [PATCH 2/2] emphasize lines Signed-off-by: Yee Hing Tong --- docs/deployment/plugins/webapi/databricks.rst | 2 +- docs/deployment/plugins/webapi/snowflake.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/deployment/plugins/webapi/databricks.rst b/docs/deployment/plugins/webapi/databricks.rst index a63522547e..69f710677c 100644 --- a/docs/deployment/plugins/webapi/databricks.rst +++ b/docs/deployment/plugins/webapi/databricks.rst @@ -308,7 +308,7 @@ Add the Databricks access token to FlytePropeller: in your YAML file as follows: .. code-block:: yaml - :emphasize-lines: 3 + :emphasize-lines: 2 configuration: inlineSecretRef: flyte-binary-external-services diff --git a/docs/deployment/plugins/webapi/snowflake.rst b/docs/deployment/plugins/webapi/snowflake.rst index 01376c499c..a4ac2d35cf 100644 --- a/docs/deployment/plugins/webapi/snowflake.rst +++ b/docs/deployment/plugins/webapi/snowflake.rst @@ -174,7 +174,7 @@ Then, add the Snowflake JWT token to FlytePropeller. in your YAML file as follows: .. code-block:: yaml - :emphasize-lines: 3 + :emphasize-lines: 2 configuration: inlineSecretRef: flyte-binary-external-services