Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executionClusterLabel #5394

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

RRap0so
Copy link
Contributor

@RRap0so RRap0so commented May 20, 2024

Tracking issue

Closes #5395

Why are the changes needed?

To add flytectlthe ability to select what execution it should go to.

What changes were proposed in this pull request?

Add a new field in the execution spec.

How was this patch tested?

With a unit test

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

@RRap0so RRap0so force-pushed the flytectl_add_ecl branch from 0244a0b to 5af6afb Compare May 20, 2024 09:28
@RRap0so RRap0so marked this pull request as ready for review May 20, 2024 09:29
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.11%. Comparing base (d04cf66) to head (bc3ba3e).
Report is 132 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5394   +/-   ##
=======================================
  Coverage   61.10%   61.11%           
=======================================
  Files         793      793           
  Lines       51164    51169    +5     
=======================================
+ Hits        31265    31270    +5     
  Misses      17027    17027           
  Partials     2872     2872           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.34% <100.00%> (+0.02%) ⬆️
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rafael Raposo <[email protected]>
@RRap0so RRap0so force-pushed the flytectl_add_ecl branch from 5af6afb to 8e1cb2a Compare May 21, 2024 08:26
eapolinario
eapolinario previously approved these changes May 28, 2024
Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eapolinario
Copy link
Contributor

docs failures are unrelated, the fix for that being #5425.

@eapolinario eapolinario merged commit 1078e09 into flyteorg:master May 28, 2024
52 of 53 checks passed
@RRap0so RRap0so deleted the flytectl_add_ecl branch May 29, 2024 09:43
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
* wAdd executionClusterLabel

Signed-off-by: Rafael Raposo <[email protected]>

* Run make -c flytectl generate

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Rafael Raposo <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core feature] Allow flytectl to set a targetExecutionCluster
2 participants