Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary joins for list node and task execution entities in flyteadmin db queries #5935

Merged
merged 3 commits into from
Oct 30, 2024

fix lint

1f462bd
Select commit
Loading
Failed to load commit list.
Merged

Remove unnecessary joins for list node and task execution entities in flyteadmin db queries #5935

fix lint
1f462bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 29, 2024 in 0s

76.11% of diff hit (target 36.84%)

View this Pull Request on Codecov

76.11% of diff hit (target 36.84%)

Annotations

Check warning on line 210 in flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go#L210 

Added line #L210 was not covered by tests

Check warning on line 169 in flyteadmin/pkg/repositories/gormimpl/node_execution_repo.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/repositories/gormimpl/node_execution_repo.go#L168-L169 

Added lines #L168 - L169 were not covered by tests

Check warning on line 108 in flyteadmin/pkg/repositories/gormimpl/task_execution_repo.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/repositories/gormimpl/task_execution_repo.go#L107-L108 

Added lines #L107 - L108 were not covered by tests

Check warning on line 150 in flyteadmin/pkg/repositories/gormimpl/task_execution_repo.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/repositories/gormimpl/task_execution_repo.go#L149-L150 

Added lines #L149 - L150 were not covered by tests

Check warning on line 153 in flyteadmin/pkg/repositories/gormimpl/task_execution_repo.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/repositories/gormimpl/task_execution_repo.go#L152-L153 

Added lines #L152 - L153 were not covered by tests

Check warning on line 156 in flyteadmin/pkg/repositories/gormimpl/task_execution_repo.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/repositories/gormimpl/task_execution_repo.go#L155-L156 

Added lines #L155 - L156 were not covered by tests
View more details on Codecov