Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support per-launch plan notification template #6064

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

avoid direct access to proto value

fde5626
Select commit
Loading
Failed to load commit list.
Open

Feat: Support per-launch plan notification template #6064

avoid direct access to proto value
fde5626
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 30, 2024 in 0s

37.09% (+0.01%) compared to ab04192

View this Pull Request on Codecov

37.09% (+0.01%) compared to ab04192

Details

Codecov Report

Attention: Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.

Project coverage is 37.09%. Comparing base (ab04192) to head (fde5626).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/admin/common.pb.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6064      +/-   ##
==========================================
+ Coverage   37.08%   37.09%   +0.01%     
==========================================
  Files        1318     1318              
  Lines      132284   132347      +63     
==========================================
+ Hits        49062    49100      +38     
- Misses      78950    78975      +25     
  Partials     4272     4272              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.