Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of issues with pupil benchmarking #59

Open
4 of 7 tasks
eozd opened this issue Apr 14, 2020 · 0 comments · Fixed by #60
Open
4 of 7 tasks

List of issues with pupil benchmarking #59

eozd opened this issue Apr 14, 2020 · 0 comments · Fixed by #60
Labels
bug Something isn't working TODO We should work on this in the future
Milestone

Comments

@eozd
Copy link
Collaborator

eozd commented Apr 14, 2020

Summary

This is a list of known issues with the pupil benchmarking, (examples/pspm_pupil) that needs to be addressed before the results are publishable

  1. All the pupil files need to be reimported using the new Eyelink import with no filtering during import
  • In addition to pupil, gaze and marker channels, blink and saccade channels also need to imported so that blink/saccade filtering can be applied
  • Once this is done, files should be put to examples/pspm_pupil/data in the current structuring.
  1. Sometimes pspm_glm crashes due to the inability of pspm_prepdata to handle NaN values. The crash logs can be found in experiment 2 logs in examples/pspm_pupil/log/exp2 folder in science cloud
  2. Valid fixations filtering in experiment 7 seems to be crashing. This issue needs to be handled, similarly by checking the logs in examples/pspm_pupil/log/exp7.
  3. Some Cohen's D scores seem to be negative. Although this is theoretically possible, I am not sure if this should be happening at all. This issue needs to be investigated
  4. In experiment 1, given a dataset, score values seem to be constant with respect to different parameter combinations. (Should be fixed with PsPM PR @ Mult NaN ratio with 100 in extract_segments bachlab/PsPM#108)
  5. Some score values are returned as NULL; however, this is not a bug. When the exclusion threshold is too low, none of the subjects in a dataset are fitted.
  6. Recording geometry should be set properly in examples/pspm_pupil/libcommon/pp_pfe; currently it is set to one of the auto modes for convenience.
@eozd eozd added bug Something isn't working TODO We should work on this in the future labels Apr 14, 2020
@eozd eozd added this to the v0.1.0 milestone Apr 14, 2020
@eozd eozd closed this as completed in #60 Apr 15, 2020
@eozd eozd reopened this Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working TODO We should work on this in the future
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant