Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divolt opens as a Chrome Custom Tab and not a PWA #3

Open
daemonspudguy opened this issue Aug 2, 2022 · 5 comments
Open

Divolt opens as a Chrome Custom Tab and not a PWA #3

daemonspudguy opened this issue Aug 2, 2022 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@daemonspudguy
Copy link

Divolt doesn't appear to work as a PWA, as this apk which is supposed to act like any other PWA if I understand how TWAs work, opens a Chrome Custom Tab. The Revolt app opens as a PWA, for what it's worth.

@ggtylerr
Copy link

ggtylerr commented Aug 2, 2022

The Divolt and Revolt apps are pretty much the same thing, the only difference is that one of them opens up Divolt and that one (for whatever reason) still shows the address bar.

Unfortunately I'm not sure what's causing it. My best guess is that there's a string value somewhere that still leads to app.revolt.chat being the trusted URL instead of divolt.xyz. But if that was the case then I'd have no idea where it is.

@ggtylerr ggtylerr added the help wanted Extra attention is needed label Aug 2, 2022
@daemonspudguy
Copy link
Author

This in the twa-manifest might be it, but I don't know.

image

@ggtylerr
Copy link

ggtylerr commented Aug 3, 2022

It's not. That's the package ID, which the only thing it changes is the path to source files. (It's staying as chat.revolt.app.twa so upstream changes don't break that much)

@daemonspudguy
Copy link
Author

There's mismatch between the packageId in the manifest and the gradle scripts.

@ggtylerr
Copy link

ggtylerr commented Aug 3, 2022

Application ID =/= Package ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants