Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing fight categories duplicates entries #61

Closed
fmuecke opened this issue Jan 5, 2021 · 0 comments · Fixed by #80
Closed

Editing fight categories duplicates entries #61

fmuecke opened this issue Jan 5, 2021 · 0 comments · Fixed by #80
Labels
bug Something isn't working Single-Mode Single tournament mode

Comments

@fmuecke
Copy link
Owner

fmuecke commented Jan 5, 2021

Version used: 1.10 beta

How to reproduce:

  1. Open Fight Category Manger (single tournament)
  2. add a new entry
  3. accept changes and close dialog
  4. re-open manager --> entries have doubled
@fmuecke fmuecke added the bug Something isn't working label Jan 5, 2021
fmuecke added a commit that referenced this issue Jan 6, 2021
@fmuecke
editing of fight categories is now live (fixes #61)
d434d7e 
- saving to/loading from temporary string is not needed anymore
- changes are signalled back to the main app via accept/reject of the dialog
- added label to warn that changes are immediate
fmuecke added a commit that referenced this issue Jan 6, 2021
@fmuecke
removed customizable column layout for fighter import/export to simpl…
afa3385 
…ify program code (single tournament)

- fixed value separator to ';'
- column-layout for import/export is no longer customizable (simplified parsing)
- distinguish between loading and importing of the fighters (fixes #61 as loading clears the list)
- removed unused code
- improved error handling
- Extended settings page no longer needed as format specifier for import/export is obsolete now
@fmuecke fmuecke added the Single-Mode Single tournament mode label Feb 8, 2025
@mahartwig mahartwig mentioned this issue Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Single-Mode Single tournament mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fight category fix mahartwig/Ipponboard
1 participant
@fmuecke