-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iPadOS' Safari 13 is not being detected anymore #404
Comments
Can you paste the actual report url instead of a screenshot? Thanks! |
I have updated the gem to the 2.6.1 version. Still no luck. I have also tried silly if statement:
and suprisingly it does not work on safari 13 as well. Looking for other options... |
@fnando do you have any quick ideas about a hacky solution to the problem? From what I have found so far, it will be difficult to parse any info that makes sense, cause it's missing from iPad Safari's user agent. I was thinking about using JS with template tag, to render the contents conditionally based on touch support + screen size, will try to make it work today. |
any updates on this @fnando ? |
I finally got the time to handle this issue: the problem is that Safari's user agent doesn't add device identifiers anymore, which means one cannot further detect whether the device is an iPad or not. |
Sent previous message a little bit too early… 🤦♂️ The user agent from my iPad running Safari on ipadOS 13 is The user agent we have on file for testing Safari 6 on iPad looks like this: As you can see above, we don't have the |
🤷♂️ The only "[SOLUTION]" you can do as far as I know now, is to change your Safari Settings manually to set the
🙏 Just praying to Apple dev team to change it! @fnando I think this issue shouldn't be closed, add some label if you want, but in my opinion should be Open |
From technical perspective @fnando is kind of right. The issue is not directly the gem's issue, as the gem only reads what the browser sends. In order to overcome that problem you would need to target iPad with it's screen size and dpi in example to make it work as you want. |
@zohaib-sarwar-confiz As @mkbctrl mentioned, there's no fix for this other than manually changing your iPad's user agent or waiting for Apple to revert this change, as suggested by @maguri.
Just found out Github's pinned tickets. I'm using that! |
Description
Issue originally occured on the Safari 13.1, newest iPad ( not pro ).
How to reproduce
Example partial we are rendering for mobile and tablet like devices. Works perfectly on Firefox, Chrome, even Edge. Safari 12 is also performing fine.
You can go to http://vehiculum.de with browserstack in example and the that the filters in the main header of the homepage are behaving differently:
Safari 13:
![Screenshot 2019-10-17 at 18 06 51](https://user-images.githubusercontent.com/10107362/67026878-effedb00-f108-11e9-9c86-2ebf88ecda8e.png)
Safari 12 - desired behavior:
![Screenshot 2019-10-17 at 18 07 26](https://user-images.githubusercontent.com/10107362/67027058-35bba380-f109-11e9-8c6c-6535ae10073f.png)
Software:
Report
The text was updated successfully, but these errors were encountered: