Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation and parameter setting #42

Open
fserva opened this issue Nov 19, 2021 · 2 comments
Open

documentation and parameter setting #42

fserva opened this issue Nov 19, 2021 · 2 comments

Comments

@fserva
Copy link

fserva commented Nov 19, 2021

Hi @fnemina, I am a new user to pyOSOAA and I think it is a really useful software. Thanks for sharing it!

I'd like to ask if a list of the various possibilities to update parameters is documented somewhere.
For example, I am not sure if the aerosol height scale ap.ha

self.ha = ha
can be modified.

Thank you

@fnemina
Copy link
Owner

fnemina commented Nov 19, 2021

Hello @fserva , you can update all the possible variables in OSOAA from pyOSOAA except for a few that I have not implemented yet. However aerosol scale height should be implemented.

It is best to consult the OSOAA for better understanding of how all this variables can be adjusted. You can find it here in the doc section.

Please let me know if you need more information about this.

Best! Fran

@fserva
Copy link
Author

fserva commented Nov 20, 2021

Thanks @fnemina for the quick feedback! I guess in this case implementation should be not too difficult, thanks to the comprehensive documentation of OSOAA. I guess after SetMot in the AP class one could add something like:

 def SetHa(self, ha=2.0):
        """ Define aerosol scale height
            ha          Aerosol scale height (km)
        """
        self.ha = ha

and maybe update test_osoaa.py and/or the notebook. Just let me know if you agree to have pull requests for these kind of changes, or prefer to take care of it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants