Upgrading Ruby to 3.5.5, Rails to 7.1.4

.envrc

@@ -14,7 +14,7 @@ if [[ $OS == "darwin" ]]; then
   PATH_add ${VOLTA_HOME}/bin
 
   export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES
-  export V8HOME=$(brew --prefix v8@3.15)
+  export V8HOME=$(brew --prefix v8)
   export CPPFLAGS="$CPPFLAGS -I ${brew_prefix}/include -I ${V8HOME}/include"
   export LDFLAGS="$LDFLAGS -L ${brew_prefix}/lib -L ${V8HOME}/lib"
 fi

.github/workflows/lint.yml

@@ -19,7 +19,7 @@ jobs:
 
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.2.3'
+          ruby-version: '3.3.5'
           bundler-cache: true
 
       - name: RuboCop

.github/workflows/rspec.yml

@@ -56,7 +56,7 @@ jobs:
 
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.2.3'
+          ruby-version: '3.3.5'
           bundler-cache: true
 
       - shell: bash

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-08-02 21:17:29 UTC using RuboCop version 1.65.0.
+# on 2024-09-19 23:27:34 UTC using RuboCop version 1.66.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -16,26 +16,26 @@ Lint/UnmodifiedReduceAccumulator:
   Exclude:
     - 'app/helpers/shifts_helper.rb'
 
-# Offense count: 7
+# Offense count: 10
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
 # AllowedMethods: refine
 Metrics/BlockLength:
   Max: 63
 
-# Offense count: 12
+# Offense count: 14
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
-  Max: 14
+  Max: 13
 
-# Offense count: 50
+# Offense count: 54
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 46
 
-# Offense count: 10
+# Offense count: 12
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
-  Max: 16
+  Max: 15
 
 # Offense count: 3
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
@@ -59,7 +59,7 @@ RSpec/DescribeClass:
   Exclude:
     - 'spec/lib/fnf/music_submissions_spec.rb'
 
-# Offense count: 1
+# Offense count: 2
 RSpec/MultipleExpectations:
   Max: 3
 
@@ -76,7 +76,7 @@ RSpec/NamedSubject:
     - 'spec/lib/fnf/csv_reader_spec.rb'
     - 'spec/models/ticket_request_spec.rb'
 
-# Offense count: 84
+# Offense count: 86
 # Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:
   Max: 6
@@ -95,7 +95,7 @@ RSpec/RepeatedExampleGroupBody:
   Exclude:
     - 'spec/models/event_spec.rb'
 
-# Offense count: 12
+# Offense count: 13
 # Configuration parameters: Database, Include.
 # SupportedDatabases: mysql, postgresql
 # Include: db/**/*.rb
@@ -113,6 +113,12 @@ Rails/BulkChangeTable:
     - 'db/migrate/20240729210234_ticket_requests_cleanup.rb'
     - 'db/migrate/20240806011401_payment_provider.rb'
 
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/CompactBlank:
+  Exclude:
+    - 'app/models/ticket_request.rb'
+
 # Offense count: 3
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
@@ -129,7 +135,7 @@ Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/shifts_helper.rb'
 
-# Offense count: 24
+# Offense count: 23
 Rails/I18nLocaleTexts:
   Exclude:
     - 'app/controllers/events_controller.rb'
@@ -153,6 +159,7 @@ Rails/NotNullColumn:
     - 'db/migrate/20130226221916_add_user_to_ticket_request.rb'
     - 'db/migrate/20130311213508_add_event_id_to_ticket_request.rb'
 
+# Offense count: 1
 Rails/OutputSafety:
   Exclude:
     - 'app/mailers/ticket_request_mailer.rb'
@@ -173,12 +180,11 @@ Rails/ReversibleMigration:
     - 'db/migrate/20240728223048_event_prices_as_integers.rb'
     - 'db/migrate/20240729210234_ticket_requests_cleanup.rb'
 
-# Offense count: 3
+# Offense count: 2
 # Configuration parameters: ForbiddenMethods, AllowedMethods.
 # ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all
 Rails/SkipsModelValidations:
   Exclude:
-    - 'app/controllers/application_controller.rb'
     - 'app/controllers/ticket_requests_controller.rb'
     - 'app/models/user.rb'
 
@@ -197,7 +203,7 @@ Rake/Desc:
   Exclude:
     - 'Rakefile'
 
-# Offense count: 94
+# Offense count: 98
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
@@ -217,7 +223,7 @@ Style/GuardClause:
   Exclude:
     - 'app/controllers/application_controller.rb'
 
-# Offense count: 34
+# Offense count: 50
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https

.ruby-version

@@ -1 +1 @@
-3.2.3
+3.3.5