diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index eddd7191..58a10268 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2024-05-10 09:35:40 UTC using RuboCop version 1.63.4. +# on 2024-05-18 20:18:04 UTC using RuboCop version 1.63.5. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -16,28 +16,23 @@ Lint/UnmodifiedReduceAccumulator: Exclude: - 'app/helpers/shifts_helper.rb' -# Offense count: 33 +# Offense count: 34 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 62 -# Offense count: 4 +# Offense count: 6 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode. # AllowedMethods: refine Metrics/BlockLength: Max: 47 -# Offense count: 3 -# Configuration parameters: CountComments, CountAsOne. -Metrics/ClassLength: - Max: 161 - -# Offense count: 10 +# Offense count: 11 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: Max: 13 -# Offense count: 43 +# Offense count: 50 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 58 @@ -45,7 +40,7 @@ Metrics/MethodLength: # Offense count: 1 # Configuration parameters: CountComments, CountAsOne. Metrics/ModuleLength: - Max: 114 + Max: 112 # Offense count: 9 # Configuration parameters: AllowedMethods, AllowedPatterns. @@ -59,7 +54,7 @@ Naming/MethodParameterName: Exclude: - 'spec/support/time_extensions.rb' -# Offense count: 20 +# Offense count: 22 # Configuration parameters: Prefixes, AllowedPatterns. # Prefixes: when, with, without RSpec/ContextWording: @@ -74,7 +69,7 @@ RSpec/DescribeClass: Exclude: - 'spec/lib/fnf/music_submissions_spec.rb' -# Offense count: 25 +# Offense count: 29 # Configuration parameters: AllowSubject. RSpec/MultipleMemoizedHelpers: Max: 12 @@ -87,7 +82,7 @@ RSpec/NamedSubject: - 'spec/lib/fnf/csv_reader_spec.rb' - 'spec/models/ticket_request_spec.rb' -# Offense count: 74 +# Offense count: 86 # Configuration parameters: AllowedGroups. RSpec/NestedGroups: Max: 6 @@ -140,7 +135,6 @@ Rails/HelperInstanceVariable: Rails/I18nLocaleTexts: Exclude: - 'app/controllers/events_controller.rb' - - 'app/controllers/home_controller.rb' - 'app/controllers/jobs_controller.rb' - 'app/controllers/passwords_controller.rb' - 'app/controllers/payments_controller.rb' @@ -151,12 +145,14 @@ Rails/I18nLocaleTexts: - 'app/models/site_admin.rb' - 'app/models/user.rb' -# Offense count: 1 +# Offense count: 3 # Configuration parameters: Database, Include. # SupportedDatabases: mysql # Include: db/**/*.rb Rails/NotNullColumn: Exclude: + - 'db/migrate/20130225033247_add_name_to_user.rb' + - 'db/migrate/20130226221916_add_user_to_ticket_request.rb' - 'db/migrate/20130311213508_add_event_id_to_ticket_request.rb' # Offense count: 9 @@ -190,12 +186,6 @@ Rails/ThreeStateBooleanColumn: - 'db/migrate/20140616030905_change_camping_type_on_ticket_requests.rb' - 'db/migrate/20150609064608_add_agrees_terms_to_ticket_requests.rb' -# Offense count: 1 -# Configuration parameters: TransactionMethods. -Rails/TransactionExitStatement: - Exclude: - - 'app/models/ticket_request.rb' - # Offense count: 2 # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -210,7 +200,7 @@ Rake/Desc: Exclude: - 'Rakefile' -# Offense count: 84 +# Offense count: 87 # Configuration parameters: AllowedConstants. Style/Documentation: Enabled: false @@ -223,17 +213,16 @@ Style/FrozenStringLiteralComment: Exclude: - 'app/models/application_record.rb' -# Offense count: 7 +# Offense count: 6 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. Style/GuardClause: Exclude: - 'app/controllers/application_controller.rb' - - 'app/controllers/payments_controller.rb' - 'app/controllers/ticket_requests_controller.rb' - 'app/models/event.rb' -# Offense count: 15 +# Offense count: 25 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https diff --git a/Gemfile.lock b/Gemfile.lock index 14df7054..5b80c648 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -85,7 +85,7 @@ GEM annotate (3.2.0) activerecord (>= 3.2, < 8.0) rake (>= 10.4, < 14.0) - asciidoctor (2.0.22) + asciidoctor (2.0.23) ast (2.4.2) attribute_normalizer (1.2.0) awesome_print (1.9.2) @@ -138,7 +138,7 @@ GEM colorize (0.8.1) concurrent-ruby (1.2.3) connection_pool (2.4.1) - countries (6.0.0) + countries (6.0.1) unaccent (~> 0.3) country_select (9.0.0) countries (> 5.0, < 7.0) @@ -226,7 +226,7 @@ GEM mini_mime (1.1.5) mini_racer (0.12.0) libv8-node (~> 21.7.2.0) - minitest (5.22.3) + minitest (5.23.0) msgpack (1.7.2) multi_json (1.15.0) mutex_m (0.2.0) @@ -247,17 +247,17 @@ GEM net_http_unix (0.2.2) newrelic_rpm (9.9.0) nio4r (2.7.3) - nokogiri (1.16.4-aarch64-linux) + nokogiri (1.16.5-aarch64-linux) racc (~> 1.4) - nokogiri (1.16.4-arm-linux) + nokogiri (1.16.5-arm-linux) racc (~> 1.4) - nokogiri (1.16.4-arm64-darwin) + nokogiri (1.16.5-arm64-darwin) racc (~> 1.4) - nokogiri (1.16.4-x86-linux) + nokogiri (1.16.5-x86-linux) racc (~> 1.4) - nokogiri (1.16.4-x86_64-darwin) + nokogiri (1.16.5-x86_64-darwin) racc (~> 1.4) - nokogiri (1.16.4-x86_64-linux) + nokogiri (1.16.5-x86_64-linux) racc (~> 1.4) orm_adapter (0.5.0) parallel (1.24.0) @@ -329,16 +329,17 @@ GEM redis-client (>= 0.22.0) redis-client (0.22.1) connection_pool - regexp_parser (2.9.0) + regexp_parser (2.9.2) relaxed-rubocop (2.5) - reline (0.5.6) + reline (0.5.7) io-console (~> 0.5) request_store (1.7.0) rack (>= 1.4) responders (3.1.1) actionpack (>= 5.2) railties (>= 5.2) - rexml (3.2.6) + rexml (3.2.8) + strscan (>= 3.0.9) rouge (4.2.1) rspec (3.13.0) rspec-core (~> 3.13.0) @@ -364,7 +365,7 @@ GEM rspec-mocks (~> 3.13) rspec-support (~> 3.13) rspec-support (3.13.1) - rubocop (1.62.1) + rubocop (1.63.5) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) @@ -384,10 +385,10 @@ GEM rubocop-minitest (0.35.0) rubocop (>= 1.61, < 2.0) rubocop-ast (>= 1.31.1, < 2.0) - rubocop-performance (1.20.2) + rubocop-performance (1.21.0) rubocop (>= 1.48.1, < 2.0) - rubocop-ast (>= 1.30.0, < 2.0) - rubocop-rails (2.24.1) + rubocop-ast (>= 1.31.1, < 2.0) + rubocop-rails (2.25.0) activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) @@ -426,6 +427,7 @@ GEM railties (>= 6.0.0) stringio (3.1.0) stripe (11.4.0) + strscan (3.1.0) temple (0.10.3) thor (1.3.1) tilt (2.3.0) @@ -453,7 +455,7 @@ GEM websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) yard (0.9.36) - zeitwerk (2.6.13) + zeitwerk (2.6.14) PLATFORMS aarch64-linux