-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIG doesn't encode query correctly. #1897
Comments
I think it's better if we do encode it. The = character isn't a problem but the '&' symbol would be. |
Example: if my query was: Then the '&' would interfere with the URL and it would think everything after the & was the next argument. |
Ex.: this would be an invalid URL ?daoKey=businessDAO&q:Simon&Simon |
This should be closed and we should not create issues or track them within GitHub issues. I have created a corresponding issue JIRA so that we can track it in our current sprint. https://nanopay.atlassian.net/browse/CPF-336 @kgrgreer .. please close this bug within GitHub issues. |
It has been merged. |
DIG isn't encoding the query string properly. So if my query is countryId=CA, it writes the URL as q=countryId=CA, which doesn't work. It should be encoded and be q=countryId%3DCA to work properly,
FYI: @nanoscott
The text was updated successfully, but these errors were encountered: