Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIG doesn't encode query correctly. #1897

Open
kgrgreer opened this issue Feb 11, 2019 · 6 comments
Open

DIG doesn't encode query correctly. #1897

kgrgreer opened this issue Feb 11, 2019 · 6 comments
Assignees
Labels

Comments

@kgrgreer
Copy link
Collaborator

DIG isn't encoding the query string properly. So if my query is countryId=CA, it writes the URL as q=countryId=CA, which doesn't work. It should be encoded and be q=countryId%3DCA to work properly,

FYI: @nanoscott

@minsunny
Copy link
Contributor

@jlhughes @kgrgreer This can be close? Seems working well and already encoded inside

@kgrgreer
Copy link
Collaborator Author

I think it's better if we do encode it. The = character isn't a problem but the '&' symbol would be.

@kgrgreer
Copy link
Collaborator Author

Example: if my query was:
businessName:Simon & Simon

Then the '&' would interfere with the URL and it would think everything after the & was the next argument.

@kgrgreer
Copy link
Collaborator Author

Ex.: this would be an invalid URL ?daoKey=businessDAO&q:Simon&Simon

@nanoscott
Copy link
Contributor

This should be closed and we should not create issues or track them within GitHub issues. I have created a corresponding issue JIRA so that we can track it in our current sprint.

https://nanopay.atlassian.net/browse/CPF-336

@kgrgreer .. please close this bug within GitHub issues.

@minsunny
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants