Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests are incorrectly returning strings instead of hashes #34

Open
DigitallyBorn opened this issue Feb 26, 2019 · 0 comments · May be fixed by #36
Open

Requests are incorrectly returning strings instead of hashes #34

DigitallyBorn opened this issue Feb 26, 2019 · 0 comments · May be fixed by #36

Comments

@DigitallyBorn
Copy link
Contributor

DigitallyBorn commented Feb 26, 2019 •
edited
Loading

It seems as though there is a bug in determining the Content-Type returned by the Aliyun API which causes some requests to return the response body as strings instead of parsing the JSON into hashes.
@DigitallyBorn DigitallyBorn changed the title list_servers should return Server models Requests are incorrectly returning strings instead of hashes Feb 26, 2019
DigitallyBorn added a commit to Rigor/fog-aliyun that referenced this issue Feb 26, 2019
@DigitallyBorn
Correct bug detecting content type and parsing json responses
30e8c06 
This is likely a breaking bug fix, since requests will now _correctly_ parse the response body as json and return a hash, instead of returning the body as a string.

Fixes fog#34
@DigitallyBorn DigitallyBorn linked a pull request Feb 26, 2019 that will close this issue
Open
DigitallyBorn added a commit to Rigor/fog-aliyun that referenced this issue Feb 26, 2019
@DigitallyBorn
Correct bug detecting content type and parsing json responses
e773454 
This is likely a breaking bug fix, since requests will now _correctly_ parse the response body as json and return a hash, instead of returning the body as a string.

Fixes fog#34
DigitallyBorn added a commit to Rigor/fog-aliyun that referenced this issue Apr 4, 2019
@DigitallyBorn
Correct bug detecting content type and parsing json responses
c5fff68 
This is likely a breaking bug fix, since requests will now _correctly_ parse the response body as json and return a hash, instead of returning the body as a string.

Fixes fog#34
DigitallyBorn added a commit to Rigor/fog-aliyun that referenced this issue Apr 24, 2019
@DigitallyBorn
Correct bug detecting content type and parsing json responses
d2f05e3 
This is likely a breaking bug fix, since requests will now _correctly_ parse the response body as json and return a hash, instead of returning the body as a string.

Fixes fog#34
DigitallyBorn added a commit to Rigor/fog-aliyun that referenced this issue Oct 9, 2019
@DigitallyBorn
Correct bug detecting content type and parsing json responses
fc87f9d 
This is likely a breaking bug fix, since requests will now _correctly_ parse the response body as json and return a hash, instead of returning the body as a string.

Fixes fog#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct bug detecting content type and parsing JSON responses Rigor/fog-aliyun
1 participant
@DigitallyBorn