Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatibility issue with github.com/quic-go/quic-go v0.45.1 #396

Open
limbo127 opened this issue Jun 24, 2024 · 5 comments · May be fixed by #399
Open

incompatibility issue with github.com/quic-go/quic-go v0.45.1 #396

limbo127 opened this issue Jun 24, 2024 · 5 comments · May be fixed by #399

Comments

@limbo127
Copy link

hello,
with latest go-quick release we have an incompatibility issue
github.com/quic-go/quic-go v0.45.1

github.com/folbricht/routedns

../../dohclient.go:343:9: cannot use &quicConnection{…} (value of type *quicConnection) as quic.EarlyConnection value in return statement: *quicConnection does not implement quic.EarlyConnection (wrong type for method NextConnection)
have NextConnection() quic.Connection
want NextConnection(context.Context) (quic.Connection, error)

@cbuijs
Copy link
Contributor

cbuijs commented Jun 24, 2024

Same here. Needed to downgrade (or not upgrade) to a previous version of quic-go (it still works with v0.43.1).

@folbricht
Copy link
Owner

I'm traveling this without access to a dev machine. But if anyone wants to try to make a PR for it I can approve it

@cbuijs
Copy link
Contributor

cbuijs commented Jun 24, 2024

@folbricht That sounds like "Sitting on the beach with a margarita" :-).

I might give it a shot later, but I suck at these kind of things :-)

@folbricht folbricht linked a pull request Jul 3, 2024 that will close this issue
@folbricht
Copy link
Owner

Can you try out the issue-396 branch? It compiles but I haven't fully tested it yet

@cbuijs
Copy link
Contributor

cbuijs commented Jul 3, 2024

Compile works indeed when including issue-396 branch. The resulting executable seems to be working just fine. Will run it for a while to see if somethings pops up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants