Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: aerc code diff is too hard to see when using night theme #653

Closed
4 tasks done
calebdw opened this issue Oct 25, 2024 · 5 comments · May be fixed by #654
Closed
4 tasks done

bug: aerc code diff is too hard to see when using night theme #653

calebdw opened this issue Oct 25, 2024 · 5 comments · May be fixed by #654
Labels
bug Something isn't working stale

Comments

@calebdw
Copy link

calebdw commented Oct 25, 2024 •
edited
Loading

Did you check docs and existing issues?

  • I have read all the tokyonight.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of tokyonight.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.11.x

Operating system/version

PopOS

Describe the bug

Hello!

Please see the following screenshot, the diff colors are too dim and are quite difficult to see in aerc when using the night theme

image

CC: @rizqicy

Thanks!

Steps To Reproduce

  • Open an email with a git diff when using the night theme

Expected Behavior

I would like the text to be a brighter green/red
@calebdw calebdw added the bug Something isn't working label Oct 25, 2024
@calebdw calebdw changed the title bug: aerc code diff is too hard to see when using tokyonight_night theme bug: aerc code diff is too hard to see when using night theme Oct 25, 2024
@calebdw
Copy link
Author

calebdw commented Oct 25, 2024

Perhaps the following would be a better color choice?

- diff_add.fg=#20303b
+ diff_add.fg=#9ece6a
- diff_del.fg=#37222c
+ diff_del.fg=#f7768e

image

I can open a PR if this is agreeable

@rizqicy
Copy link
Contributor

rizqicy commented Oct 25, 2024

Hi there,
Perhaps i forgot to check the diff view last time 😅
please create the PR. thx

@calebdw calebdw mentioned this issue Oct 28, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
@calebdw
Copy link
Author

calebdw commented Dec 2, 2024

😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aerc): make night theme diff colors more readable calebdw/tokyonight.nvim
2 participants
@calebdw @rizqicy