FontBakery crashes or does not terminate when no matching checks are found

[Hoolean]

When specifying check IDs manually on the command line, FontBakery crashes or does not terminate when there are no checks matching the given IDs.

Reproducing

1. Obtain a TTF:

   • e.g. NotoSansEgyptianHieroglyphs-Regular.ttf

2. Install the latest version of FontBakery:

    python3 -m venv venv
    . venv/bin/activate
    pip install fontbakery

3. Run FontBakery on the TTF, specifying a check ID that does not exist:

   1. In serial:

   fontbakery check-universal NotoSansEgyptianHieroglyphs-Regular.ttf --check thisdoesnotexist

   2. In parallel:

   fontbakery check-universal NotoSansEgyptianHieroglyphs-Regular.ttf --check thisdoesnotexist --auto-jobs

Expected result

FontBakery shows an error message, or exits with a report showing that 0 tests were performed.

Actual result

• Depending on how FontBakery was invoked:

  1. In serial: FontBakery crashes on completion:

  Start ... running 0 individual check executions.
  
  Total:
  
      ERROR: 0
      FATAL: 0
      FAIL: 0
      WARN: 0
      INFO: 0
      SKIP: 0
      PASS: 0
  
  []   0%
  
  DONE!
  
  ...
  
  Traceback (most recent call last):
    File "/home/harryd/Experiments/fontbakery-stall/venv/bin/fontbakery", line 8, in <module>
      sys.exit(main())
    File "/home/harryd/Experiments/fontbakery-stall/venv/lib/python3.10/site-packages/fontbakery/cli.py", line 61, in main
      run_profile_check(subcommand_module[6:])
    File "/home/harryd/Experiments/fontbakery-stall/venv/lib/python3.10/site-packages/fontbakery/cli.py", line 34, in run_profile_check
      sys.exit(check_profile_main(module.profile))
    File "/home/harryd/Experiments/fontbakery-stall/venv/lib/python3.10/site-packages/fontbakery/commands/check_profile.py", line 473, in main
      return 1 if tr.worst_check_status.weight >= args.error_code_on.weight else 0
  AttributeError: 'NoneType' object has no attribute 'weight'
  

  2. In parallel: FontBakery blocks forever and never terminates:

  Start ... running 0 individual check executions.
  
      ERROR: 0
      FATAL: 0
      FAIL: 0
      WARN: 0
      INFO: 0
      SKIP: 0
      PASS: 0
      (not finished): 0
  
  ░ []   0%
  

Environment

• Python: 3.10.12
• FontBakery: 0.10.8 release
• OS: Ubuntu 22.04.3 LTS (WSL)

[Hoolean]

Also: happy 2️⃣ 0️⃣ 2️⃣ 4️⃣ !

[davelab6]

Happy new year :) Thanks for reporting this. This seems trivial to fix to me, so I've converted it to an issue, and will close the discussion here.