Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com.google.fonts/check/STAT/gf_axisregistry] marks "Slant" Value anything other than Default as "Fail" #4876

Open
mitradranirban opened this issue Oct 31, 2024 · 0 comments

Comments

@mitradranirban
Copy link

Observed behaviour

My font's STAT table has 2 instances in Slant Axis -20 = Oblique and 0 = Default

Fontbakery check/STAT/gf_axisregistry reports

FAIL
On the font variation axis 'slnt', the name 'Oblique' is not among the expected ones (Default) according to the Google Fonts Axis Registry.

[code: invalid-name]

Expected behaviour

as per data in https://github.com/googlefonts/axisregistry/blob/main/Lib/axisregistry/data/slant.textproto

tag: "slnt"
display_name: "Slant"
min_value: -90
max_value: 90
default_value: 0
precision: 0
fallback {
name: "Default"
value: 0
}
fallback_only: false
illustration_url: "slant.svg"
description:
"Adjust the style from upright to slanted. Negative values produce"
" right-leaning forms, also known to typographers as an 'oblique' style."
" Positive values produce left-leaning forms, also called a 'backslanted'"
" or 'reverse oblique' style."

So Value 0 should be "Default", any value < 0 should be "Oblique", and any value > 0 sould be "Reverse Oblique"

Resources and steps needed to reproduce

FontBakery version 0.12.10
OS Ubuntu 22.04
Python version 3.10.12
Fontbakery Command used
fontbakery check-googlefonts -l WARN --full-lists --succinct --badges out/badges --html out/fontbakery/fontbakery-report.html --ghmarkdown out/fontbakery/fontbakery-report.md *.ttf
Font file (zipped) attached
Samaano[slnt,wdth,wght].zip

@mitradranirban mitradranirban changed the title [com.google.fonts/check/STAT/gf_axisregistry] marks anything other than Default as "Fail" [com.google.fonts/check/STAT/gf_axisregistry] marks "Slant" Value anything other than Default as "Fail" Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant