Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: foodcoops/foodsoft
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 11aedea364f778b6237d87be3eb9349774272041
Choose a base ref
..
head repository: foodcoops/foodsoft
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7474d83abd0d77d7d9e66d98674a78f0fa55c30e
Choose a head ref
Showing with 3 additions and 1 deletion.
  1. +3 −1 doc/article_units_fork_architecture_changes.md
4 changes: 3 additions & 1 deletion doc/article_units_fork_architecture_changes.md
View file
Original file line number Diff line number Diff line change
@@ -45,6 +45,8 @@ So we decided provide an alternative for `sharedlists` with a foodsoft feature w

The API docs for supplier sharing can be automatically exported to swagger - see the [docs on how to do that](https://github.com/foodcoops/foodsoft/blob/84518a7cddac8dfb728213ca2544f5d0067c20d3/doc/API.md#api-endpoint-documentation). (Note the petstore.swagger.io link there doesn't work and even if it would, it would lead to `main`'s API, not to this branch's. You'll need to generate them yourself for now.)

The API endpoint handling sharing is `/shared_suppliers/{uuid}/articles`.

Also see [rails migration here](https://github.com/foodcoops/foodsoft/blob/84518a7cddac8dfb728213ca2544f5d0067c20d3/db/migrate/20240726083742_alter_suppliers_sharing_fields.rb).

Not all of `sharedlists`' features have been ported yet. Specifically the [SMTP article list import](https://github.com/foodcoopsat/foodsoft_hackathon/issues/37) is missing. However, it has been agreed, that this is one of the issues, that should only be done after merging this PR (to not further bloat it).
@@ -129,7 +131,7 @@ To facilitate migrating from the legacy `article_versions.unit` field, the [migr
2. Show a form grouping the existing articles by their plain text units. For each article an attempt is made to preset UNECE unit fields.
3. The user may then manually alter the suggested values and choose which article to migrate by (un-)checking them in the form.
4. Old orders are of course untouched by this migration (see [Article versioning above](#1-article-versioning))
5. As soon as the migration has completed, the button is no longer displayed on the articles index page.
5. As soon as the migration has completed, [`suppliers.unit_migration_completed`](https://github.com/foodcoops/foodsoft/blob/84518a7cddac8dfb728213ca2544f5d0067c20d3/db/migrate/20240726083744_add_unit_migration_completed_to_suppliers.rb) is set causing the button to no longer be displayed on the articles index page.

## Unit translations