Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve understandability of article form (labels, locales, tooltips) #50

Closed
twothreenine opened this issue Feb 4, 2024 · 3 comments
Closed

Comments

@twothreenine
Copy link
Contributor

twothreenine commented Feb 4, 2024

I've seen you've changed supplier order unit to delivery unit. Generally I'm not really happy with the texts at the moment, "Can be ordered per" does not specify whether from the supplier or by ordergroups. I think this should be clearer. My suggestions:

Hackathon article form EN drawio

internally orderable per is of course meant as an alternative suggestion, I prefer the one above though.
edit: members can order per isn't too long either

Hackathon article form DE drawio

Einheiten-Umrechnungen sounds very confusing to me. Inhalt would be a loose translation, but clearer, I guess. You could even use "content" in English. I think this would describe the main use case here best. Adding a ratio like ml/g will be the exception. I think we should explain how ratios can be used in a tooltip.

@lentschi
Copy link
Contributor

lentschi commented Feb 4, 2024

@twothreenine Those are just initial ideas (just so we can test the multi language setup on the demo server).
I'm not sure, it makes sense to discuss each single translation here.

I suggest we finish everything in English first and then discuss translations directly in the translation files (e.g. via PR). Would that be okay for you? (If so, I'd close this issue - after all there's #23 to tackle this)

@twothreenine
Copy link
Contributor Author

twothreenine commented Feb 4, 2024

I just wanted to note this for later as I thought about it.
I think it does make sense to discuss the labels of this menu together, and the tooltip thing isn't tackled by #23.

After the current issues are solved, I'd suggest we complete the translations to German and then invite ppl from the Austrian forum for a wider test, both for understandability as for bugfinding.

@lentschi
Copy link
Contributor

lentschi commented Feb 5, 2024

Okay, but please create a separate issue to discuss adding tooltips etc. I'm closing this issue now to avoid confusion.

@lentschi lentschi closed this as completed Feb 5, 2024
twothreenine added a commit that referenced this issue Jul 22, 2024
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
#83, #81 (more important)
#80, #82 (less important)
twothreenine added a commit that referenced this issue Jul 22, 2024
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
#83, #81 (more important)
#80, #82 (less important)
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)
twothreenine added a commit that referenced this issue Jul 22, 2024
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
#83, #81 (more important)
#80, #82 (less important)
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)
twothreenine added a commit that referenced this issue Jul 24, 2024
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
#83, #81 (more important)
#80, #82 (less important)
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)
twothreenine added a commit that referenced this issue Jul 24, 2024
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
#83, #81 (more important)
#80, #82 (less important)
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)
lentschi pushed a commit that referenced this issue Jul 26, 2024
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
#83, #81 (more important)
#80, #82 (less important)
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)
lentschi pushed a commit that referenced this issue Jul 26, 2024
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)
lentschi pushed a commit that referenced this issue Jul 26, 2024
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)
lentschi pushed a commit that referenced this issue Oct 11, 2024
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants