Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why i7 moved? #53

Open
declaresub opened this issue Nov 30, 2017 · 1 comment
Open

why i7 moved? #53

declaresub opened this issue Nov 30, 2017 · 1 comment

Comments

@declaresub
Copy link

What is the idea behind the decision branch i7 moved? As best as I can tell, it serves only as a possible short-circuit for skipping the next decisions moved_permanently, moved_temporarily, gone_permanently.

@andreineculau
Copy link
Member

Once again, sorry for the late reply.

You are right that it's a shortcircuit, as it is also seen from the diagram. So if you have the means to confirm that the resource has moved e.g. /profile/1234567890 has moved to /user/andrei.neculau, then this hook should return true, allowing for the other moved_* hooks to decide which type of resource-move was performed.

In retrospect, I agree with what you're implying i.e. why have it at all? I'll leave this open, and mark it as enhancement (simplification).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants