Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have cargo-msrv use cargo-like workspace inheritance #1026

Open
foresterre opened this issue Oct 14, 2024 · 0 comments
Open

Have cargo-msrv use cargo-like workspace inheritance #1026

foresterre opened this issue Oct 14, 2024 · 0 comments

Comments

@foresterre
Copy link
Owner

foresterre commented Oct 14, 2024

Implement actual issue from #1023

The difficulty with doing this by default, i.e. when running cargo msrv verify from a workspace root, is that you'll have to disambiguate between "running verify against a root package" or "running verify against all workspace members plus the root package"

I would have imagined that it would inherit the behavior of cargo — use the default workspace members — which is the root if one exists, or all members if one doesn't exist or --workspace is passed.

(along with @eitsupi, I'm a dev of prql. I'm separately a maintainer of insta, where we do exactly that)

Thanks for the feedback!

I never realized that the following is the cargo default for a virtual workspace:

or all members if one doesn't exist

I agree that inheriting cargo's behavior is most logical.

Originally posted by @foresterre in #1023 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant