Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-binstall fails to install cargo-msrv on macos-latest runner #1033

Open
babichjacob opened this issue Oct 19, 2024 · 5 comments · Fixed by #1034
Open

cargo-binstall fails to install cargo-msrv on macos-latest runner #1033

babichjacob opened this issue Oct 19, 2024 · 5 comments · Fixed by #1034

Comments

@babichjacob
Copy link
Contributor

babichjacob commented Oct 19, 2024

Here is the workflow run on macos-latest:
https://github.com/babichjacob/cargo-msrv-repro/actions/runs/11419532112/job/31774207776

The part of note is under the "Run cargo binstall -y --verbose cargo-msrv" heading. It takes over 4 minutes because of this issue: I see in the logs that cargo-binstall is attempting a ton of different permutations of what the possible file name it's looking for should be, but it's tragically not trying the correct one for this platform.

The workflow has the same job run on ubuntu-latest and windows-latest (in the left sidebar) and those succeed; not sure how.

@foresterre
Copy link
Owner

foresterre commented Oct 19, 2024

What macos target do you use?

As far as I'm aware, these are the common ones right? (I don't use mac myself):

image

Let's try whether your PR works; if not I'll investigate this further.

@foresterre
Copy link
Owner

I'm surprised though!

The default scheme should work just fine I think: https://github.com/cargo-bins/cargo-binstall/blob/92a022bad41abdae4221a6e901e455359cee03fe/SUPPORT.md#defaults

@babichjacob
Copy link
Contributor Author

babichjacob commented Oct 19, 2024

What macos target do you use?

macos-latest was switched to Apple Silicon a few months ago, so it's aarch64-apple-darwin

@babichjacob
Copy link
Contributor Author

The default scheme should work just fine I think: https://github.com/cargo-bins/cargo-binstall/blob/92a022bad41abdae4221a6e901e455359cee03fe/SUPPORT.md#defaults

I think this is referring to the name of the executable inside of the archive file, once it's already located and downloaded. Yeah, this part of the documentation confuses me too

@foresterre
Copy link
Owner

The default scheme should work just fine I think: cargo-bins/cargo-binstall@92a022b/SUPPORT.md#defaults

I think this is referring to the name of the executable inside of the archive file, once it's already located and downloaded. Yeah, this part of the documentation confuses me too

I'll revert it in #1035

@foresterre foresterre changed the title At least on the GitHub Actions macos-latest runner, trying to install cargo-msrv with Binstall (cargo-binstall) fails to download the binary from the GitHub release and instead compiles it from source cargo-binstall fails to install cargo-msrv on macos-latest runner Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants