Logging

[aarbi]

I recently built an app on top of rr7, I had to add some Restful API endpoint, so I added them as rr routes (not added to express) since I want to the implementation to be as much as possible decoupled from http server.
Now with that in mind, I want your thoughts about the best way integrate logging that serves most of the use cases if possible.
Each request would have a spanId or requestId header and would be great if we can append it to the logs output throughout logging emitted while handling a request. I faced some challenges before when tried to use AppContext to pass a logger instance around, so I am just bringing this up here because I would love to see a robust logging toolings integrated into this great stack.

I can help implement it but I will need some thoughts about the best way to do it.
Thank you!

[AlemTuzlak]

We have actually created a PoC for logging but we haven't still ported it back to the base-stack, my co-founder has worked on this part so i'll let him @thomasfr provide some feedback here

[aarbi]

thank you!

[thomasfr]

Hi @aarbi

I recently built an app on top of rr7, I had to add some Restful API endpoint, so I added them as rr routes (not added to express) since I want to the implementation to be as much as possible decoupled from http server.

May i ask you, what you mean with "wanted the restful api endpoints as much as possible decoupled from http server" and why?

As Alem has already mentioned, if you are using those API endpoints exclusively from the same RR7 app, I recommend keeping the API endpoints within the RR7 app. This approach provides better type hints and enhances the developer experience. Additionally, as you noted, I suggest adding a logger instance or getLogger function to the AppLoadContext. This allows you to obtain a new logger from the context of loaders and actions, for example. With base-stack, you can extend the context in that file: https://github.com/forge-42/base-stack/blob/deee68930f29657b3c9aaf926e30f2072dd2001d/app/server/context.ts.

In the getLoadContext function, you also have access to the current request through c.req, since c is a standard Hono context object (https://hono.dev/docs/api/context). This is where you can add, generate, or retrieve an existing request ID from the incoming request headers, to the current context. Once you have the request ID in the getLoadContext function, you can use it in your logger, which you add to the context there as well.

[aarbi]

I meant that I didn't want to define the route in express or Hono routes file. I needed those API endpoints to be defined in react router as part of the framework, since the code behind them can be used in loadeds/actions to render some pages as well.
Also if I decide to move from Express to Hono for example or any other runtime (like deno) the changes would be minimal.

I would also love to have a solution that doesn't require passing loggers a parameters in functions if ever we use one from a module. It is like each module has its own Logger instance generated, yet they are "context" aware. If that is doable that would be great

[aarbi]

And thanks btw!