Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUnit should be the default test framework #35

Open
agoncal opened this issue Jun 11, 2014 · 15 comments
Open

JUnit should be the default test framework #35

agoncal opened this issue Jun 11, 2014 · 15 comments
Milestone

Comments

@agoncal
Copy link

agoncal commented Jun 11, 2014

The command arquillian-setup should be optional, but if we use it, JUnit should be the default. At the moment, arquillian-setup asks you which test framework (TestNG or Junit). By default, it shouldn't ask, and use JUnit

[ArqEntity.java]$ arquillian-setup

[0] - testng
[1] - junit

***ERROR*** Test Framework must be specified.
***ERROR*** Test Framework Version must be specified.
@bartoszmajsak
Copy link
Contributor

Why JUnit in particular?

@agoncal
Copy link
Author

agoncal commented Jun 11, 2014

Because it's the one most commonly used : http://www.google.com/trends/explore#q=junit%2C%20testng&cmpt=q

@bartoszmajsak
Copy link
Contributor

Well that's questionable ;) But I agree there should be the default for convenience.
EDIT: Ok, new keywords are ambiguous :)

@agoncal
Copy link
Author

agoncal commented Jun 11, 2014

Well, one or the other, really. A default would be great as more and more Forge commands have defaults (less typing) and it would be good if Arquillian also had more defaults

@bartoszmajsak
Copy link
Contributor

Sure, I was trying to be a smartass today ;) I assume we are still talking about 1.x? If that's for 2.x I guess we will need to first bring the changes to this repository.

I will have a look at it this weekend.

Cheers!

@aslakknutsen
Copy link
Member

@bartoszmajsak yea, very questionable.. I always prefer cucumber salad over junit coding.. ;)

@agoncal
Copy link
Author

agoncal commented Jun 11, 2014

All these issues are about 2.x

@aslakknutsen
Copy link
Member

@bartoszmajsak comments are based on this branch; https://github.com/aslakknutsen/plugin-arquillian/tree/forge2

I will push it to upstream master. Just gotta get the test suite fully functional again

@bartoszmajsak
Copy link
Contributor

@aslakknutsen can you create a label for 2.x so that we can categorize issues?

@aslakknutsen aslakknutsen added this to the 2.0 milestone Jun 11, 2014
@aslakknutsen
Copy link
Member

@bartoszmajsak it exists :)

@aslakknutsen
Copy link
Member

@bartoszmajsak 2.0 milestone

@gastaldi
Copy link
Member

Now in the correct thread: i agree that JUnit should be the default choice. Who uses TestNG nowadays? ;)

@aslakknutsen
Copy link
Member

As @bartoszmajsak pointed out, the list is actually a a lot longer then those two option. Those two are just the ones that are currently built in.

Maybe it would make sense to split them somehow.. (especially when we integrate all extensions in general)

Instead of 'setup arquillian', then user could give some pre hint to what h's trying to do, e.g.;

arquillian-test-bdd-functional-frontend <-- (named just to make the command complicated atm)

@agoncal
Copy link
Author

agoncal commented Jun 11, 2014

Something like this ?

arquillian-create-test
arquillian-create-bdd-test
arquillian-create-selenium-test

@aslakknutsen
Copy link
Member

in theory they could just be aliases, but.. yea..

Some way to describe and provide a 'solution', not just dump single components on a user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants