Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in the import section of a class stops Roaster.parseUnit() #334

Open
bmarolleau opened this issue Nov 10, 2024 · 1 comment
Open

Comments

@bmarolleau
Copy link

Using Roaster 2.29.
Adding a comment in the import part of a class with double slash prefix seems to stop parseUnit method, consequence: getInternal() is incomplete which results getting unit.getGoverningType() to return a org.jboss.forge.roaster.model.impl.JavaPackageInfoImpl class (unit.getClass()) instead of org.jboss.forge.roaster.model.source.JavaClassSource .
Comments with /* */ format does not impact Roaster.parseUnit().

Example:

package com.mypackage 
import java.sql.Date; //this comment is problematic 
//this comment is problematic 
/*this one is not */
public class myClass { 
}

I suppose that Java standard allows comments in this section of the code. A workaround is of course to remove these comments.
But is it a normal behavior or known issue ? thanks for your help,

@gastaldi
Copy link
Member

Sounds like a parsing bug. Thanks for the reproducer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants