Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genapp: Difficult to change and set proper socket filename. #73

Open
clarsonneur opened this issue Sep 7, 2018 · 0 comments
Open

genapp: Difficult to change and set proper socket filename. #73

clarsonneur opened this issue Sep 7, 2018 · 0 comments

Comments

@clarsonneur
Copy link
Contributor

forjj through goforjj use <plugin>.yaml: /plugin: <value> to connect to the proper socket.

If we created a new plugin with a wrong name, the cli.go is generated and will never be updated if we do not remove it, before a go generate

So, even if we change <plugin>.yaml, forjj will take care of it, but not the plugin until we change manually the cli.go in load_plugin_def function

We need forjj and plugins to be more coherent.
The rule should be:

  • if <plugin>.yaml: /runtime/serviice/socket:<value> is set, use it in both forjj and the plugin.
  • if not set, use <plugin>.yaml: /plugin: <value> in both forjj and the plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant