You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Currently PlaybackArtworkContainer is a PlaybackArtwork wrapped with a redux enhancer. Its only usage is inside a PlaybackAlbumArtwork.
Problems
It synchronously builds a list of tracks to enqueue. Ideally the tracks are fetched based on the album id asynchronously so all songs of an album don't need to be pre-loaded.
It pays the cost of being de-coupled from PlaybackAlbumArtwork without any benefits.
The text was updated successfully, but these errors were encountered:
PlaybackArtworkContainer will be useful when creating PlaybackArtistArtwork. (#7)
Some additional problems we need to consider:
Figure out loading when already loading. If something is already loading and another loading is started, the first loading should be cancelled (or at least its result should be ignored).
Dynamic loading is possible, but it isn't used anywhere. Use it.
It doesn't look like PlaybackArtwork handles rendering a loading animation.
Each instance of PlaybackArtworkContainer will have an identifier.
State
The state will hold the currently loading item's instance identifier.
Actions
Start Loading
The start loading action will be dispatched when loading has been started. It will have the instance identifier of the PlaybackArtworkContainer. Updates the currently loading item's instance identifier.
Done Loading
The done loading action will be dispatched when loading has completed or failed. If for the last loading item's instance identifier, set the loading state to not loading. It will also have an action which will be dispatched if the id passed in the action is the same as the currently loading item.
UI
The queue won't change until loading is complete. Nothing needs to be changed with the UI. The loading animation (2) could be the ripple effect from spinkit. http://tobiasahlin.com/spinkit/
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently PlaybackArtworkContainer is a PlaybackArtwork wrapped with a redux enhancer. Its only usage is inside a PlaybackAlbumArtwork.
Problems
The text was updated successfully, but these errors were encountered: