Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcli * action: check instruction improvements #542

Open
rsenden opened this issue May 21, 2024 · 0 comments
Open

fcli * action: check instruction improvements #542

rsenden opened this issue May 21, 2024 · 0 comments
Labels
effort:medium Medium effort needed to implement/fix fcli-actions feature A feature that's on the roadmap or in development prio:medium Medium priority

Comments

@rsenden
Copy link
Contributor

rsenden commented May 21, 2024

To make the check instruction more versatile, we may want to consider some of the potential improvements listed below.

  • Add fail/passLevel or similar attributes to check: element:
    • Identify whether a failure should be treated as informational, warning or failure
    • Identify whether success should be treated as informational or warning
    • For example, an informational/warning failure would still result in 0 exit code
    • What should we name this attribute exactly, and how should this be presented in the output?
  • Add global checks configuration, defining:
    • Output location (default stdout)
    • Exit codes (default 0 for success, for failure: 1, 100, ...?)
    • What output to write (passed checks, failed checks and/or overall status)
  • Custom exit codes:
    • Per check (but how to combine?)
    • In global checks configuration (see above)
    • Ability to increase based on number of failed checks or similar?
@rsenden rsenden added feature A feature that's on the roadmap or in development fcli-actions labels May 21, 2024
@rsenden rsenden added prio:medium Medium priority effort:medium Medium effort needed to implement/fix labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:medium Medium effort needed to implement/fix fcli-actions feature A feature that's on the roadmap or in development prio:medium Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant