Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ActionRunner #544

Open
rsenden opened this issue May 21, 2024 · 0 comments
Open

Refactor ActionRunner #544

rsenden opened this issue May 21, 2024 · 0 comments
Labels
effort:high Lot of effort needed to implement/fix enhancement New feature or request fcli-actions prio:medium Medium priority

Comments

@rsenden
Copy link
Contributor

rsenden commented May 21, 2024

The ActionRunner class is now one big class with some inner classes for handling top-level action elements like parameters or steps. This makes the class fairly difficult to navigate and maintain. Ideally, this class should be structured in the same way as the action model classes, with a separate class handling each individual step type for example.

In the current implementation, we use instance fields to store data relevant for all step types, so we'd need to refactor this to easily access this data from the various classes in the action runner class structure. For example, we could have an ActionContext object that allows for accessing localData, parent contexts and utility methods; this object would then be passed around to the various methods (or constructors) for each of these 'step handlers'.

@rsenden rsenden added enhancement New feature or request fcli-actions labels May 21, 2024
@rsenden rsenden added prio:medium Medium priority effort:high Lot of effort needed to implement/fix labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:high Lot of effort needed to implement/fix enhancement New feature or request fcli-actions prio:medium Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant