Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in code of schedule-pool-list condition in virtual server python file in module #2

Open
iden83 opened this issue Oct 6, 2022 · 0 comments

Comments

@iden83
Copy link

iden83 commented Oct 6, 2022

Condition in virtual server python part of module (lines 323-326) is not correct and should be fixed:

https://github.com/fortinet-ansible-dev/ansible-galaxy-fortiadc-collection/blob/galaxy/1.0.1/plugins/modules/fadcos_virtual_server.py#L323

There is condition evaluated:

if list_need_update(module.params['source_pool_list'], data['schedule-pool-list']):
    data['schedule-pool-list'] = list_to_str(
        module.params['source_pool_list'])
    res = True

using 'schedule-pool-list' should be replaced with 'source-pool-list' hence above condition shall become:

if list_need_update(module.params['source_pool_list'], data['source-pool-list']):
    data['source-pool-list'] = list_to_str(
        module.params['source_pool_list'])
    res = True

In our project to properly interact with FortiADC device updates we are manually change those lines in the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant