Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Bach/Fugue/bwv_846 + issue in voice attribution #18

Open
leleogere opened this issue Feb 10, 2025 · 2 comments
Open

Typo in Bach/Fugue/bwv_846 + issue in voice attribution #18

leleogere opened this issue Feb 10, 2025 · 2 comments

Comments

@leleogere
Copy link

In Bach/Fugues/bwv_846, the measure 16 looks like that:
Incorrect measure 16

According to the following two references (here and here), the colored note should be a G sharp, however, it is natural in ASAP (there isn't any sharps at the clef):
ref1
ref2

I can open a PR to fix that, but I came across that measure for another reason, the voicing in the MusicXML seems wrong:
Image

You can see that the A in voice 1 (blue) in the middle of the bar is tied to the A in voice 3 (orange). In the two references above, the two chords in voice 1 at beats 2 and 2.5 are split into two voices. Should I fix the score and attribute the bottom note of those chords to the voice 3? That way, the voice 3 won't have any gaps, and the A's tie won't change voice (while none of those issues is really forbidden, I feel like those changes would clean up this measure).

By the way, I've spotted a couple more scores with cross-voice ties, that could easily be fixed by swapping two voices. Should I open a PR for those too? (I'll likely fix them anyway on my fork, but should I bring back those changes here?)

Thank you!

@fosfrancesco
Copy link
Owner

Hello Leo, very short answer: yes please!

I won't be able to check this more in detail or to merge pull requests until the 5 of march unfortunately.
If it is urgent for you (also about the other pull requests you sent) send me a private email!

@leleogere
Copy link
Author

Thanks for you answer!

No problem for the slow merging process, I work mainly from my fork anyway. I bring back my modifications here as they could be useful for other people, but no problem if you consider some of them out of scope of ASAP, just drop them!

I'll do a PR for this fix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants