-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] auto switch GET
-> POST
when request body is added
#181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert all changes made to this file. You can keep a local version and not commit it to the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@opxdelwin Why did you mark this conversation as resolved. It is the reviewer's task to review the changes and mark it resolved. Also, you have still not reverted all the changes that you made to this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for marking the conversation as resolved prematurely. I wasn't aware that it's the reviewer's responsibility to mark it resolved.
Regarding the .gitignore change, I made it to prevent the auto-generated hive files during testing from cluttering the codebase. Let me know whether to still revert changes.
I understand now that I should have let the reviewers close the conversation. I'll make sure to follow the correct process next time. Thanks for bringing it to my attention.
pubspec.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert removal of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ashitaprasad, is there any specific reason? It's suggested by flutter.dev to not necessarily track pubspec.lock
as they're auto generated at flutter pub get
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@opxdelwin API Dash is an application which itself is also a package (has pubspec.yaml). Read the same link carefully, at the bottom it says For application packages, we recommend that you commit the pubspec.lock file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, looks like I misunderstood of standalone exe's being not included. I'll do my research, and revert back the changes for time being...
Closing this PR as we will leave it upto the user to switch instead of auto switching for now. |
Implemented Features:
Additional Changes:
Description:
This pull request addresses #178. The task involved implementing automatic switching to the POST method from GET when a user adds a request body, thereby enhancing the user experience. Additionally, a message is displayed in the snackbar to notify the user of this switch.
Furthermore, tests have been added to ensure the reliability and functionality of the implemented features. Basic support structure for Riverpod providers testing has also been incorporated into the codebase.
Please review and provide any feedback or suggestions.
Thank you.