-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add websocket support #210
Closed
sebastianbuechler
wants to merge
21
commits into
foss42:main
from
sebastianbuechler:feature/add-websocket-support
Closed
Feature/add websocket support #210
sebastianbuechler
wants to merge
21
commits into
foss42:main
from
sebastianbuechler:feature/add-websocket-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
@ashitaprasad In contrast to #215 this works with the same request model and dedicated WebSocket states. This allows for simultaneous connections to WebSocket servers. Let me know if adaptions are needed or further clarification on the specs. |
@sebastianbuechler Kindly make this change #307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WebSocket support
This feature adds basic WebSocket support to apidash. It is according to the sketches in #15, but the headers are not yet incorporated into the web socket connection. Including the body does not make sense for WebSockets if I'm not mistaken, so we should remove it as well.
My proposal for the query params and the headers: If they get changed, the connection should be dropped and the user needs to manually reconnect, as the server connection will change. Maybe the UI should be adapted for this.
Thus open points:
Testing is a bit harder for WebSockets to begin with. Maybe inject an HTTP client manually to mock it?
Related Issues
Checklist
flutter test
) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.