Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature Websocket Support #215

Closed
wants to merge 2 commits into from

Conversation

mmjsmohit
Copy link
Contributor

PR Description

This pull request introduces basic support for WebSockets, following the specifications discussed in issue #15. The changes include modifications to tests to align with the new request and response model. While the initial implementation is in place, there are still some outstanding issues that need resolution, along with additional test coverage.

Key Changes

  1. WebSocket Integration: The PR establishes bidirectional communication channels between clients and servers using the WebSocket protocol. This enables real-time data exchange without breaking the connection or requiring additional HTTP requests.

  2. Test Updates: The existing tests have been adapted to match the new request and response patterns. However, further testing and validation are necessary to ensure robustness.

Next Steps

  1. Write Tests: Comprehensive test coverage is essential. We need to create test cases that cover various scenarios, including edge cases.
  2. Enhance UI: I would like to enhance the UI including adding icons for protocols and improving the user experience for dealing with realtime API testing.
  3. Error Handling: Build robust error handling for Websockets.

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

  • Yes
  • No, and this is why: please replace this line with details on why tests have not been included
  • I need help with writing tests

@mmjsmohit mmjsmohit changed the title Add feature websocketsupport Add feature Websocket Support Feb 27, 2024
@sebastianbuechler
Copy link

sebastianbuechler commented Feb 27, 2024

@mmjsmohit I just checked out your PR and I'm afraid there are major issues with the core WebSocket support. I'm getting null check errors through much of the testing and basic feature like connection states for multiple connections are wrong. Since my PR (#210) is already fully functional maybe we can see how to integrate with eachother. What do you think?

@animator
Copy link
Member

@mmjsmohit Please make this change #307

@ashitaprasad
Copy link
Member

@mmjsmohit Can you please resolve the conflicts and let us know

@ashitaprasad
Copy link
Member

@mmjsmohit There is an issue in the state management. Every time, I create a new Websocket request, it shows connected even when no data has been entered. This should not happen. Also, currently there are a lot of conflicts that need to be resolved. So, I am closing this PR.
Please make a new PR resolving all the issues.

@mmjsmohit
Copy link
Contributor Author

Sure @ashitaprasad! Will make a new PR with resolved conflicts and issues after I finish implementing MQTT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Websocket Support
4 participants