Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Protocol Selector Dropdown #321

Closed
wants to merge 4 commits into from
Closed

Add Protocol Selector Dropdown #321

wants to merge 4 commits into from

Conversation

mmjsmohit
Copy link
Contributor

PR Description

This PR adds a drop-down to select the protocol. Any further protocol support can be added by modifying the ProtocolType enum in consts.dart.

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

  • Yes
  • No

@animator
Copy link
Member

  • Is not visible in light mode.
  • The dropdown should be sleek. Its height is too big.

@mmjsmohit
Copy link
Contributor Author

I have made the changes and the dropdown looks like this:
Light Mode:
image

Dark Mode:
image

Let me know if this looks good to go!

@ashitaprasad
Copy link
Member

Closing this PR due to major refactoring of the request model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protocol selection dropdown
3 participants
@mmjsmohit @animator @ashitaprasad