Remove Paypal plugin #309
Open
Remove Paypal plugin #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add plugins to autodeployment with docker
* Implement option to add link to privacy policy
* add footer link for event + organizer
* Replace pkg_resources with import importlib_metadata
* Do not repeat questions in form field of ticket form
Reviewer's Guide by SourceryThis pull request removes the PayPal plugin from the source code and prepares it to be used as an external plugin for Docker deployment. The changes primarily involve updating dependency management and removing PayPal-related files from the project structure. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @odkhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider refactoring the dependency handling code in set_github_token.py to reduce duplication between Stripe and PayPal logic.
- The PR description mentions adding PayPal as an external plugin for Docker deployment, but there are no visible changes related to Docker configuration. Could you clarify if additional changes are needed to complete this transition?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
* implement customer feature * implement customer SSO provider & client * add docs for customer functions
* Use master branch in docker-pr workflow * Update workflow test postgres version to 12
…mplate if eventyay video is installed (fossasia#270)
… before (fossasia#277) * implement script to create customer account for customer placed order before
* update popup content when user join online event
* update join_online_event placeholder * update mobile view for ticket layout
fossasia#289) * add space between notification and header * update translation for menu bar * remove duplicate messageid
* update translation for user dropdown menu
* update dummy data and update link to eventyay.com * update git workflow * update docs --------- Co-authored-by: lcduong <[email protected]>
* Unified QR response * Added EventName to the Unified QR field
…ssasia#310) * implement sso login feature * format code
* implement sso login feature * format code * implement eventyay-common implement page organizer/team to create/update/delete organizer/team * implement organizer/team create/update/delete
* set base path using force_script_name * get base_path from config file * add slash for media url * remove hard code url with url template
* implement sso login feature * format code * implement eventyay-common implement page organizer/team to create/update/delete organizer/team * implement organizer/team create/update/delete * implement common event create/update * implement common event create/update * fix isort
* set base path using force_script_name * get base_path from config file * add slash for media url * remove hard code url with url template * default base_path is /tickets * update base_path for account dropdown menu
odkhang
force-pushed
the
development
branch
from
98d72f5
to
69a456a
Compare
odkhang
force-pushed
the
remove-paypal-plugin
branch
from
2af381f
to
f2c6833
Compare
mariobehling
requested changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements of this PR:
https://github.com/fossasia/eventyay-tickets-paypal
Summary by Sourcery
Remove the PayPal plugin from the source code and configure it as an external plugin for Docker deployment. Update the project dependencies to handle the PayPal plugin externally using a GitHub token.
Deployment: