Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Made write a feedback optional #2366

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

ranjsa
Copy link
Member

@ranjsa ranjsa commented Sep 27, 2019

Fixes #2355

Changes:

  • Removed showing of error message when text field was left empty during submitting feedback by just giving rate .

  • Changed the string write a feedback to Submit Feedback in content_event.xml file

Screenshots for the change:

ezgif com-video-to-gif

@auto-label auto-label bot added the feature label Sep 27, 2019
@iamareebjamal
Copy link
Member

Name should be displayed with feedback

@ranjsa
Copy link
Member Author

ranjsa commented Sep 28, 2019

@iamareebjamal @liveHarshit I need a littele help ,
I want to add name of the user who has submitted feedback , how can i do that as we are getting only comment and rating from the server in this json response . Or should I include name from the server side.

{
  "meta": {
    "count": 1
  },
  "data": [
    {
      "relationships": {
        "event": {
          "links": {
            "self": "/v1/feedbacks/1/relationships/event",
            "related": "/v1/feedbacks/1/event"
          }
        },
        "user": {
          "links": {
            "self": "/v1/feedbacks/1/relationships/user",
            "related": "/v1/feedbacks/1/user"
          }
        }
      },
      "attributes": {
        "rating": "4",
        "deleted-at": null,
        "comment": "Awesome event"
      },
      "type": "feedback",
      "id": 1,
      "links": {
        "self": "/v1/feedbacks/1"
      }
    }
  ],
  "jsonapi": {
    "version": "1.0"
  },
  "links": {
    "self": "/v1/events/1/feedbacks"
  }
}

@iamareebjamal
Copy link
Member

Include name from server

@ranjsa
Copy link
Member Author

ranjsa commented Sep 29, 2019

Include name from server

@iamareebjamal I have created a issue on the server side regarding this and i am working on it ,
can we right now close this issue #2355 with this pull request as it is solving the issue of removing error message and making comment optional , later when i will finsh working on adding name on the server side then i will create a different pull request for that .

@iamareebjamal
Copy link
Member

close it

@ranjsa
Copy link
Member Author

ranjsa commented Sep 29, 2019

@iamareebjamal
Sir , actually I was talking about merging this PR so then the issue will close automatically .

@iamareebjamal
Copy link
Member

Once, the name is shown with review, we'll merge it. No use of merging half a feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make write a feedback optional .
2 participants