-
Notifications
You must be signed in to change notification settings - Fork 99
Publish workflow correction #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vedansh Saini <41898282+github-actions[bot]@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR corrects the Chrome Web Store publishing workflow by updating the GitHub Actions step, removing an obsolete workflow file, and adding a new version entry to the CHANGELOG. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
Blocking issues:
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
General comments:
- Adjust the CHANGELOG entry to use the correct next version (e.g., bump to v1.0.6) and replace 'No changes' with a summary of the publish workflow fix.
- Check for any remaining references to publish-chrome.yml in CI configs or documentation and update them to use the new workflow file.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Adjust the CHANGELOG entry to use the correct next version (e.g., bump to v1.0.6) and replace 'No changes' with a summary of the publish workflow fix.
- Check for any remaining references to publish-chrome.yml in CI configs or documentation and update them to use the new workflow file.
## Individual Comments
### Comment 1
<location> `.github/workflows/publish-to-chrome.yml:35` </location>
<code_context>
uses: PlasmoHQ/chrome-extension-action@v3
</code_context>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Vedansh Saini <41898282+github-actions[bot]@users.noreply.github.com>
📌 Fixes
Fixes #250
📝 Summary of Changes
removed a residual file
fixed the error in publishing.
📸 Screenshots / Demo (if UI-related)
Add screenshots, video, or link to deployed preview if applicable
✅ Checklist
👀 Reviewer Notes
Add any special notes for the reviewer here
Summary by Sourcery
Fix the Chrome Web Store publishing workflow by updating the action reference, removing an obsolete workflow file, and adding a new changelog entry.
Bug Fixes:
CI:
Documentation: