Skip to content

Conversation

@vedansh-5
Copy link
Member

@vedansh-5 vedansh-5 commented Oct 6, 2025

📌 Fixes

Fixes #250


📝 Summary of Changes

removed a residual file
fixed the error in publishing.


📸 Screenshots / Demo (if UI-related)

Add screenshots, video, or link to deployed preview if applicable


✅ Checklist

  • I’ve tested my changes locally
  • I’ve added tests (if applicable)
  • I’ve updated documentation (if applicable)
  • My code follows the project’s code style guidelines

👀 Reviewer Notes

Add any special notes for the reviewer here

Summary by Sourcery

Fix the Chrome Web Store publishing workflow by updating the action reference, removing an obsolete workflow file, and adding a new changelog entry.

Bug Fixes:

  • Correct the Chrome extension publishing step to use the proper PlasmoHQ action

CI:

  • Remove the deprecated publish-chrome.yml workflow
  • Update publish-to-chrome.yml to use PlasmoHQ/chrome-extension-action@v3

Documentation:

  • Add changelog entry for v0.1.2

Signed-off-by: Vedansh Saini <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Vedansh Saini <41898282+github-actions[bot]@users.noreply.github.com>
@vedansh-5 vedansh-5 self-assigned this Oct 6, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 6, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR corrects the Chrome Web Store publishing workflow by updating the GitHub Actions step, removing an obsolete workflow file, and adding a new version entry to the CHANGELOG.

File-Level Changes

Change Details Files
Add new version entry to CHANGELOG
  • Insert v0.1.2 header with date
  • Add placeholder “No changes” bullet
  • Maintain formatting with separators
CHANGELOG.md
Fix publish-to-chrome workflow action
  • Change action from PlasmoHQ/chrome-extension@v3 to PlasmoHQ/chrome-extension-action@v3
  • Ensure correct action reference for publishing
.github/workflows/publish-to-chrome.yml
Remove obsolete publish-chrome workflow
  • Delete deprecated publish-chrome.yml file
.github/workflows/publish-chrome.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#250 Fix the error in the Chrome extension publishing workflow.
#250 Remove any residual or obsolete workflow files related to publishing.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

Blocking issues:

  • An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)

General comments:

  • Adjust the CHANGELOG entry to use the correct next version (e.g., bump to v1.0.6) and replace 'No changes' with a summary of the publish workflow fix.
  • Check for any remaining references to publish-chrome.yml in CI configs or documentation and update them to use the new workflow file.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Adjust the CHANGELOG entry to use the correct next version (e.g., bump to v1.0.6) and replace 'No changes' with a summary of the publish workflow fix.
- Check for any remaining references to publish-chrome.yml in CI configs or documentation and update them to use the new workflow file.

## Individual Comments

### Comment 1
<location> `.github/workflows/publish-to-chrome.yml:35` </location>
<code_context>
              uses: PlasmoHQ/chrome-extension-action@v3
</code_context>

<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

*Source: opengrep*
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Vedansh Saini <41898282+github-actions[bot]@users.noreply.github.com>
@hpdang hpdang merged commit 4a1de5c into fossasia:master Oct 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Publish workflow.

2 participants