Merge pull request #37 from fotinakis/explicit-serializer-discovery

Support for explicit serializer discovery.

Author: fotinakis

lib/jsonapi-serializers/serializer.rb

@@ -211,6 +211,9 @@ def evaluate_attr_or_block(attribute_name, attr_or_block)
     end
 
     def self.find_serializer_class_name(object)
+      if object.respond_to?(:jsonapi_serializer_class_name)
+        return object.jsonapi_serializer_class_name.to_s
+      end
       "#{object.class.name}Serializer"
     end
 

spec/serializer_spec.rb

@@ -423,7 +423,7 @@ def serialize_primary(object, options = {})
       expect(JSONAPI::Serializer.serialize(post, include: ['author'])).to eq({
         'data' => expected_primary_data,
         'included' => [
-          serialize_primary(post.author, {serializer: MyApp::UserSerializer}),
+          serialize_primary(post.author, {serializer: MyAppOtherNamespace::UserSerializer}),
         ],
       })
     end
@@ -518,7 +518,7 @@ def serialize_primary(object, options = {})
         'data' => serialize_primary(post, {serializer: MyApp::PostSerializer}),
         'included' => [
           # Only the author is included:
-          serialize_primary(post.author, {serializer: MyApp::UserSerializer}),
+          serialize_primary(post.author, {serializer: MyAppOtherNamespace::UserSerializer}),
         ],
       }
       includes = ['long-comments.post.author']
@@ -542,8 +542,8 @@ def serialize_primary(object, options = {})
         # Same note about primary data linkages as above.
         'data' => serialize_primary(post, {serializer: MyApp::PostSerializer}),
         'included' => [
-          serialize_primary(first_user, {serializer: MyApp::UserSerializer}),
-          serialize_primary(second_user, {serializer: MyApp::UserSerializer}),
+          serialize_primary(first_user, {serializer: MyAppOtherNamespace::UserSerializer}),
+          serialize_primary(second_user, {serializer: MyAppOtherNamespace::UserSerializer}),
         ],
       }
       includes = ['long-comments.user']
@@ -571,7 +571,7 @@ def serialize_primary(object, options = {})
             include_linkages: ['user'],
           }),
           # Note: post.author does not show up here because it was not included.
-          serialize_primary(comment_user, {serializer: MyApp::UserSerializer}),
+          serialize_primary(comment_user, {serializer: MyAppOtherNamespace::UserSerializer}),
         ],
       }
       includes = ['long-comments', 'long-comments.user']
@@ -598,7 +598,7 @@ def serialize_primary(object, options = {})
         'included' => [
           serialize_primary(long_comments.first, {serializer: MyApp::LongCommentSerializer}),
           serialize_primary(long_comments.last, {serializer: MyApp::LongCommentSerializer}),
-          serialize_primary(post.author, {serializer: MyApp::UserSerializer}),
+          serialize_primary(post.author, {serializer: MyAppOtherNamespace::UserSerializer}),
         ],
       }
       # Also test that it handles string include arguments.

spec/support/serializers.rb

@@ -17,6 +17,10 @@ class LongComment
   class User
     attr_accessor :id
     attr_accessor :name
+
+    def jsonapi_serializer_class_name
+      'MyAppOtherNamespace::UserSerializer'
+    end
   end
 
   class PostSerializer
@@ -41,12 +45,6 @@ class LongCommentSerializer
     has_one :post
   end
 
-  class UserSerializer
-    include JSONAPI::Serializer
-
-    attribute :name
-  end
-
   # More customized, one-off serializers to test particular behaviors:
 
   class SimplestPostSerializer
@@ -141,3 +139,13 @@ class MultipleAttributesSerializer
     attributes :title, :body
   end
 end
+
+# Test the `jsonapi_serializer_class_name` override method for serializers in different namespaces.
+# There is no explicit test for this, just implicit tests that correctly serialize User objects.
+module MyAppOtherNamespace
+  class UserSerializer
+    include JSONAPI::Serializer
+
+    attribute :name
+  end
+end