Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CUDA Unit Tests in GH Workflows #39

Open
fabianlim opened this issue Jun 24, 2024 · 2 comments
Open

Enable CUDA Unit Tests in GH Workflows #39

fabianlim opened this issue Jun 24, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@fabianlim
Copy link
Contributor

fabianlim commented Jun 24, 2024

  • Currently we are skipping some FOAK tests because they require CUDA to run, but will be good to enable CUDA in the github actions so that we can run these tests.
  • Also we should have some automated regression tests. These need to be run in custom github runners. The flow could be:
    1. maintainer triggers selected regressions by discretion.
    2. tests run and report results (either in a custom system or committing back to a gitub artifact)
    3. show some regression comparisons with existing benches.
    4. If a full bench is run and mantainer decides to update the benches, then download the corresponding artifact and commit
@fabianlim fabianlim changed the title Enable CUDA Unit Tests Enable CUDA Unit Tests in GH Workflows Jun 24, 2024
@fabianlim
Copy link
Contributor Author

Not doing for now

@fabianlim
Copy link
Contributor Author

On second thoughts let’s open this again

@fabianlim fabianlim reopened this Nov 8, 2024
@fabianlim fabianlim added the help wanted Extra attention is needed label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant