fix(fmt): fn estimate_size() account for opening brackets (#11887)

* fix(fmt): `fn estimate_size()` account for opening brackets if
`config.bracket_spacing = true`

* fix: rmv debug logs

* fix: match on `[` too

Author: 0xrusowsky

crates/fmt/src/state/mod.rs

@@ -386,12 +386,17 @@ impl State<'_, '_> {
 
                 if prev_needs_space {
                     size += 1;
-                } else if !first
-                    && let Some(c) = line.chars().next()
-                    && matches!(c, '&' | '|' | '=' | '>' | '<' | '+' | '-' | '*' | '/' | '%' | '^')
-                {
-                    // if the line starts with an operator, a space or a line break are required.
-                    size += 1
+                } else if !first && let Some(char) = line.chars().next() {
+                    // A line break or a space are required if this line:
+                    // - starts with an operator.
+                    // - starts with a bracket and fmt config forces bracket spacing.
+                    match char {
+                        '&' | '|' | '=' | '>' | '<' | '+' | '-' | '*' | '/' | '%' | '^' => {
+                            size += 1
+                        }
+                        '}' | ')' | ']' if self.config.bracket_spacing => size += 1,
+                        _ => (),
+                    }
                 }
                 first = false;
 
@@ -415,7 +420,7 @@ impl State<'_, '_> {
                 // - ends with ',' a line break or a space are required.
                 // - ends with ';' a line break is required.
                 prev_needs_space = match line.chars().next_back() {
-                    Some('(') | Some('{') => self.config.bracket_spacing,
+                    Some('[') | Some('(') | Some('{') => self.config.bracket_spacing,
                     Some(',') | Some(';') => true,
                     _ => false,
                 };

crates/fmt/testdata/ReprosCalls/110.fmt.sol

@@ -132,6 +132,11 @@ contract Orchestrator {
             self.feeGrowthGlobal0X128 - lower.feeGrowthOutside0X128 - upper.feeGrowthOutside0X128;
         feeGrowthInside0X128 =
             self.feeGrowthGlobal0X128 - lower.feeGrowthOutside0X128 - upper.feeGrowthOutside0X128;
+
+        // https://github.com/foundry-rs/foundry/issues/11875
+        lpTail = LpPosition({
+            tickLower: posTickLower, tickUpper: posTickUpper, liquidity: lpTailLiquidity, id: uint16(id)
+        });
     }
 
     // https://github.com/foundry-rs/foundry/issues/11834

crates/fmt/testdata/ReprosCalls/120.fmt.sol

@@ -1,4 +1,5 @@
 // config: line_length = 120
+// config: bracket_spacing = true
 function test() public {
     require(
         keccak256(abi.encodePacked("this is a long string")) == keccak256(abi.encodePacked("some other long string")),
@@ -25,7 +26,7 @@ function test() public {
     );
 
     oracleInfo =
-        abi.encode(LidoOracleInfo({base: IOracle(oracleAddress).WSTETH(), quote: IOracle(oracleAddress).STETH()}));
+        abi.encode(LidoOracleInfo({ base: IOracle(oracleAddress).WSTETH(), quote: IOracle(oracleAddress).STETH() }));
 
     return someFunction().getValue().modifyValue().negate().scaleBySomeFactor(1000).transformToTuple();
 
@@ -119,6 +120,11 @@ contract Orchestrator {
         // https://github.com/foundry-rs/foundry/issues/11835
         feeGrowthInside0X128 = self.feeGrowthGlobal0X128 - lower.feeGrowthOutside0X128 - upper.feeGrowthOutside0X128;
         feeGrowthInside0X128 = self.feeGrowthGlobal0X128 - lower.feeGrowthOutside0X128 - upper.feeGrowthOutside0X128;
+
+        // https://github.com/foundry-rs/foundry/issues/11875
+        lpTail = LpPosition({
+            tickLower: posTickLower, tickUpper: posTickUpper, liquidity: lpTailLiquidity, id: uint16(id)
+        });
     }
 
     // https://github.com/foundry-rs/foundry/issues/11834

crates/fmt/testdata/ReprosCalls/80.fmt.sol

@@ -189,6 +189,14 @@ contract Orchestrator {
             - lower.feeGrowthOutside0X128 - upper.feeGrowthOutside0X128;
         feeGrowthInside0X128 = self.feeGrowthGlobal0X128
             - lower.feeGrowthOutside0X128 - upper.feeGrowthOutside0X128;
+
+        // https://github.com/foundry-rs/foundry/issues/11875
+        lpTail = LpPosition({
+            tickLower: posTickLower,
+            tickUpper: posTickUpper,
+            liquidity: lpTailLiquidity,
+            id: uint16(id)
+        });
     }
 
     // https://github.com/foundry-rs/foundry/issues/11834

crates/fmt/testdata/ReprosCalls/original.sol

@@ -125,6 +125,10 @@ contract Orchestrator {
             self.feeGrowthGlobal0X128 - lower.feeGrowthOutside0X128 - upper.feeGrowthOutside0X128;
         feeGrowthInside0X128 = self.feeGrowthGlobal0X128
             - lower.feeGrowthOutside0X128 - upper.feeGrowthOutside0X128;
+
+        // https://github.com/foundry-rs/foundry/issues/11875
+        lpTail =
+            LpPosition({ tickLower: posTickLower, tickUpper: posTickUpper, liquidity: lpTailLiquidity, id: uint16(id) });
     }
 
     // https://github.com/foundry-rs/foundry/issues/11834