nit: shorten warning

Author: 0xClandestine

crates/lint/src/sol/gas/unwrapped_modifier_logic.rs

@@ -9,7 +9,7 @@ declare_forge_lint!(
     UNWRAPPED_MODIFIER_LOGIC,
     Severity::Gas,
     "unwrapped-modifier-logic",
-    "modifier logic should be wrapped to avoid code duplication and reduce codesize"
+    "wrap modifier logic to reduce code size"
 );
 
 impl<'ast> EarlyLintPass<'ast> for UnwrappedModifierLogic {

crates/lint/testdata/UnwrappedModifierLogic.sol

@@ -55,23 +55,23 @@ contract UnwrappedModifierLogicTest {
 
     // Bad patterns
 
-    modifier requireBuiltIn() { //~NOTE: modifier logic should be wrapped to avoid code duplication and reduce codesize
+    modifier requireBuiltIn() { //~NOTE: wrap modifier logic to reduce code size
         checkPublic(msg.sender);
         require(isOwner[msg.sender], "Not owner");
         checkPrivate(msg.sender);
         _;
         checkInternal(msg.sender);
     }
 
-    modifier assertBuiltIn() { //~NOTE: modifier logic should be wrapped to avoid code duplication and reduce codesize
+    modifier assertBuiltIn() { //~NOTE: wrap modifier logic to reduce code size
         checkPublic(msg.sender);
         assert(isOwner[msg.sender]);
         checkPrivate(msg.sender);
         _;
         checkInternal(msg.sender);
     }
 
-    modifier conditionalRevert() { //~NOTE: modifier logic should be wrapped to avoid code duplication and reduce codesize
+    modifier conditionalRevert() { //~NOTE: wrap modifier logic to reduce code size
         checkPublic(msg.sender);
         if (!isOwner[msg.sender]) {
             revert("Not owner");
@@ -81,7 +81,7 @@ contract UnwrappedModifierLogicTest {
         checkInternal(msg.sender);
     }
 
-    modifier assign(address sender) { //~NOTE: modifier logic should be wrapped to avoid code duplication and reduce codesize
+    modifier assign(address sender) { //~NOTE: wrap modifier logic to reduce code size
         checkPublic(sender);
         bool _isOwner = true;
         checkPrivate(sender);
@@ -90,7 +90,7 @@ contract UnwrappedModifierLogicTest {
         checkInternal(sender);
     }
 
-    modifier assemblyBlock(address sender) { //~NOTE: modifier logic should be wrapped to avoid code duplication and reduce codesize
+    modifier assemblyBlock(address sender) { //~NOTE: wrap modifier logic to reduce code size
         checkPublic(sender);
         assembly {
             let x := sender
@@ -100,7 +100,7 @@ contract UnwrappedModifierLogicTest {
         checkInternal(sender);
     }
 
-    modifier uncheckedBlock(address sender) { //~NOTE: modifier logic should be wrapped to avoid code duplication and reduce codesize
+    modifier uncheckedBlock(address sender) { //~NOTE: wrap modifier logic to reduce code size
         checkPublic(sender);
         unchecked {
             sender;
@@ -112,7 +112,7 @@ contract UnwrappedModifierLogicTest {
 
     event DidSomething(address who);
 
-    modifier emitEvent(address sender) { //~NOTE: modifier logic should be wrapped to avoid code duplication and reduce codesize
+    modifier emitEvent(address sender) { //~NOTE: wrap modifier logic to reduce code size
         checkPublic(sender);
         emit DidSomething(sender);
         checkPrivate(sender);

crates/lint/testdata/UnwrappedModifierLogic.stderr

@@ -1,52 +1,52 @@
-note[unwrapped-modifier-logic]: modifier logic should be wrapped to avoid code duplication and reduce codesize
+note[unwrapped-modifier-logic]: wrap modifier logic to reduce code size
   --> ROOT/testdata/UnwrappedModifierLogic.sol:LL:CC
    |
 58 |     modifier requireBuiltIn() {
    |              --------------
    |
    = help: https://book.getfoundry.sh/reference/forge/forge-lint#unwrapped-modifier-logic
 
-note[unwrapped-modifier-logic]: modifier logic should be wrapped to avoid code duplication and reduce codesize
+note[unwrapped-modifier-logic]: wrap modifier logic to reduce code size
   --> ROOT/testdata/UnwrappedModifierLogic.sol:LL:CC
    |
 66 |     modifier assertBuiltIn() {
    |              -------------
    |
    = help: https://book.getfoundry.sh/reference/forge/forge-lint#unwrapped-modifier-logic
 
-note[unwrapped-modifier-logic]: modifier logic should be wrapped to avoid code duplication and reduce codesize
+note[unwrapped-modifier-logic]: wrap modifier logic to reduce code size
   --> ROOT/testdata/UnwrappedModifierLogic.sol:LL:CC
    |
 74 |     modifier conditionalRevert() {
    |              -----------------
    |
    = help: https://book.getfoundry.sh/reference/forge/forge-lint#unwrapped-modifier-logic
 
-note[unwrapped-modifier-logic]: modifier logic should be wrapped to avoid code duplication and reduce codesize
+note[unwrapped-modifier-logic]: wrap modifier logic to reduce code size
   --> ROOT/testdata/UnwrappedModifierLogic.sol:LL:CC
    |
 84 |     modifier assign(address sender) {
    |              ------
    |
    = help: https://book.getfoundry.sh/reference/forge/forge-lint#unwrapped-modifier-logic
 
-note[unwrapped-modifier-logic]: modifier logic should be wrapped to avoid code duplication and reduce codesize
+note[unwrapped-modifier-logic]: wrap modifier logic to reduce code size
   --> ROOT/testdata/UnwrappedModifierLogic.sol:LL:CC
    |
 93 |     modifier assemblyBlock(address sender) {
    |              -------------
    |
    = help: https://book.getfoundry.sh/reference/forge/forge-lint#unwrapped-modifier-logic
 
-note[unwrapped-modifier-logic]: modifier logic should be wrapped to avoid code duplication and reduce codesize
+note[unwrapped-modifier-logic]: wrap modifier logic to reduce code size
    --> ROOT/testdata/UnwrappedModifierLogic.sol:LL:CC
     |
 103 |     modifier uncheckedBlock(address sender) {
     |              --------------
     |
     = help: https://book.getfoundry.sh/reference/forge/forge-lint#unwrapped-modifier-logic
 
-note[unwrapped-modifier-logic]: modifier logic should be wrapped to avoid code duplication and reduce codesize
+note[unwrapped-modifier-logic]: wrap modifier logic to reduce code size
    --> ROOT/testdata/UnwrappedModifierLogic.sol:LL:CC
     |
 115 |     modifier emitEvent(address sender) {