How to test a revert not caught by vm.expectRevert(); after the deprecation and removal of testFail

[monnidev]

Hello, I have an issue with an old test of mine, I cannot share the code but the test is fairly simple, it checks if an unauthorized user can perform a specific action (in this case, grant a role to themselves):

vm.startPrank(user);
vm.expectRevert();        
myContract.grantRole(
    myContract.ROLE(),
    user
);
vm.stopPrank();

This test fails:
[FAIL: next call did not revert as expected]

But when I remove vm.expectRevert(); to check what's going on, it does revert correctly:
[FAIL: AccessControlUnauthorizedAccount( user , role )]

My assumption was that the test does revert correctly but that it does so in a way not caught by vm.expectRevert();, my workaround at the time was to use testFail, unfortunately I cannot do it anymore, can you help me find a way to catch this revert? Thanks

[zerosnacks]

Hi @monnidev,

What is happening is that myContract.ROLE() is an external call that happens prior to myContract.grantRole(..) and in turn does not fail as expected. You can circumvent this by assigning myContract.ROLE() to a variable prior to calling vm.expectRevert() and then passing it into myContract.grantRole(..).