-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for curly brackets when resolving envs #2851
Comments
I can handle this if assigned. I will study the codebase, check relevant crates, implement the feature and ensure test pass. Like I did here. |
Hey, this issue will be available for taking during the ODBoost https://app.onlydust.com/hackathons/odboost-1. |
I'd like to handle this task. |
Hello, I'd like to work on this. I’m a developer with over three years of experience. ETA: 24 hours |
Can I work on this? @cptartur How i will handle this
|
May I take care of this? |
Hey @kkawula, can I get assigned to it I am new to open source contributor. |
Is this issue still available? |
<!-- Reference any GitHub issues resolved by this PR --> Closes #2851 ## Introduced changes <!-- A brief description of the changes --> - Added implementation for resolving environmental variables with curly braces ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md` --------- Co-authored-by: ddoktorski <[email protected]> Co-authored-by: Franciszek Job <[email protected]>
Which components does the task require to be changed? (think hard pls)
snforge
Description
Context:
https://foundry-rs.github.io/starknet-foundry/appendix/scarb-toml.html?highlight=tool#scarbtoml-contents
We can define profiles in
scarb.toml
and use environmental variables as values.Currently forge support such syntax:
url = "$RPC_URL"
, buturl = "${RPC_URL}"
should be possibleRequested here: https://t.me/starknet_foundry_support/5363
TODO:
starknet-foundry/crates/configuration/src/lib.rs
Lines 118 to 133 in 8ce451e
The text was updated successfully, but these errors were encountered: