Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direShell calling quit is evil: instead should throw a (sub)class of CatcheableError #63

Open
timotheecour opened this issue Oct 11, 2018 · 0 comments

Comments

@timotheecour
Copy link

timotheecour commented Oct 11, 2018

/cc @yglukhov @fowlmouth

see also https://forum.nim-lang.org/t/4042#25152: (quit considered evil: bypasses defer and try/catch/finally which might do important cleanups)

eg in $nim_D/nimx/nimx/naketools.nim it prevents doing things like:

try:
  direShell "xcodebuild", "-project", xcodeProjDir/"SDL.xcodeproj", "-target", "Static\\ Library", "-configuration", "Release", "-sdk", "macosx"&b.macOSSDKVersion, "SYMROOT=build"
except CatchableError as e:
  # process e, give an informative msg (eg to suggest alternatives like brew install sdl2), or provide fallback options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant