Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package 'nake' has an incorrect structure #68

Open
arturtamborski opened this issue Aug 29, 2019 · 1 comment
Open

Package 'nake' has an incorrect structure #68

arturtamborski opened this issue Aug 29, 2019 · 1 comment

Comments

@arturtamborski
Copy link

Hi, I've installed nake with nimble and got this warning:

nimble install nake
    Prompt: No local packages.json found, download it from internet? [y/N]
    Answer: y
Downloading Official package list
    Success Package list downloaded.
Downloading https://github.com/fowlmouth/nake using git
   Warning: Package 'nake' has an incorrect structure. The top level of the package source directory should contain at most one module, named 'nake.nim', but a file named 'nakefile.nim' was found. This will be an error in the future.
      Hint: If this is the primary source file in the package, rename it to 'nake.nim'. If it's a source file required by the main module, or if it is one of several modules exposed by 'nake', then move it into a 'nakepkg/' subdirectory. If it's a test file or otherwise not required to build the the package 'nake.nim', prevent its installation by adding `skipFiles = @["nakefile.nim"]` to the .nimble file. See https://github.com/nim-lang/nimble#libraries for more info.
  Verifying dependencies for [email protected]
 Installing [email protected]
   Building nake/nake using c backend
   Success: nake installed successfully.

I think that the structure of nim programs changed in latest version.

Here's some version info:

nimble -v
nimble v0.10.2 compiled at 2019-08-29 08:31:13
nim -v
Nim Compiler Version 0.20.2 [Linux: amd64]
Compiled at 2019-07-17
Copyright (c) 2006-2019 by Andreas Rumpf

Happy to send fix if you think that it's worth fixing.

@IcedQuinn
Copy link

This warning is still present though it has not turned in to an error.

Although it may also pose a problem for projects using Nake downstream. They will have to have a nakefile.nim which Nimble will also complain about. Not sure what to do about this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants