Add support for plugin directories #788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
force-pushed
the
refactor-plugin-registration
branch
from
84e83ea to
2ea8410
Compare
Schamper
force-pushed
the
plugin-directory
branch
from
5d4a437 to
8f1ec8f
Compare
Schamper
force-pushed
the
refactor-plugin-registration
branch
from
2ea8410 to
2192994
Compare
Schamper
force-pushed
the
plugin-directory
branch
from
8f1ec8f to
954c0f2
Compare
Schamper
force-pushed
the
refactor-plugin-registration
branch
from
2192994 to
85f4ebc
Compare
Schamper
force-pushed
the
plugin-directory
branch
from
954c0f2 to
34b3e4d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor-plugin-registration #788 +/- ##
=============================================================
Coverage 75.43% 75.43%
=============================================================
Files 296 296
Lines 25591 25593 +2
=============================================================
+ Hits 19305 19307 +2
Misses 6286 6286
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
force-pushed
the
refactor-plugin-registration
branch
2 times, most recently
from
43b0585 to
e830c4e
Compare
Schamper
force-pushed
the
refactor-plugin-registration
branch
2 times, most recently
from
19bf4e9 to
77f2144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General idea is that you create your plugin in a file called
_plugin.pyin a certain directory. That directory can then hold other files such as specific helpers. The plugin path/name is then derived from the directory path up until the module name, instead of including it.For example:
The plugin will register under the
apps.something.myapppath.Closes #890.