Make Mssql errorlog plugin more robust #978
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
==========================================
- Coverage 77.72% 77.72% -0.01%
==========================================
Files 326 326
Lines 28575 28574 -1
==========================================
- Hits 22210 22209 -1
Misses 6365 6365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
requested changes
Dec 19, 2024
Co-authored-by: Erik Schamper <[email protected]>
Co-authored-by: Erik Schamper <[email protected]>
Horofic
force-pushed
the
fix_mssql_errorlog
branch
from
c26288a to
777b34c
Compare
Horofic
force-pushed
the
fix_mssql_errorlog
branch
from
777b34c to
9132869
Compare
Schamper
requested changes
Dec 20, 2024
| subkey.name, | ||
| self.target.fs.path(subkey.subkey("SQLServerAgent").value("ErrorLogFile").value).parent, | ||
| ) | ||
| for subkey in self.target.registry.glob_ext(self.MSSQL_KEY_GLOB): |
There was a problem hiding this comment.
Maybe make this a comprehension, not sure if it'll become too large.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977