Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor is_ROI_table_valid #633

Open
tcompa opened this issue Dec 12, 2023 · 0 comments
Open

Refactor is_ROI_table_valid #633

tcompa opened this issue Dec 12, 2023 · 0 comments
Labels
ngio OME-Zarr reader/writer Tables AnnData and ROI/feature tables

Comments

@tcompa
Copy link
Collaborator

tcompa commented Dec 12, 2023

This came up during #600 and #631 (see #600 (comment)), and we are currently postponing it.

fractal_tasks_core.roi.is_ROI_table_valid, where we validate both the ROI contents and the Zarr attributes --> maybe we can refactor this one?

Not necessary for the 0.14.0 release. Who should be checking the attrs in the end? I can see that it would come from a function in fractal_tasks_core.tables to load the attrs, but we also didn't really want to have it there, right?

@tcompa tcompa added the Tables AnnData and ROI/feature tables label Dec 12, 2023
@jluethi jluethi added the ngio label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ngio OME-Zarr reader/writer Tables AnnData and ROI/feature tables
Projects
Development

No branches or pull requests

2 participants