Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zarr_dir optional when creating dataset #630

Closed
tcompa opened this issue Nov 4, 2024 · 1 comment · Fixed by #634
Closed

Make zarr_dir optional when creating dataset #630

tcompa opened this issue Nov 4, 2024 · 1 comment · Fixed by #634

Comments

@tcompa
Copy link
Collaborator

tcompa commented Nov 4, 2024

  • Starting from fractal-server 2.8.0, zarr_dir becomes optional in the dataset POST.
  • If user has no project_dir in their settings, zarr_dir becomes required (backend-side).
  • In the dataset-creation modal, let's add a description like "The main folder for OME-Zarrs of this dataset. If not set, a default subfolder of {user_settings.project_dir} will be used."
  • Upon successful dataset creation, display a temporary message showing the value of response.zarr_dir.
@jluethi
Copy link
Collaborator

jluethi commented Nov 4, 2024

This sounds great.

Once we validate that those defaults are working well in practice, I'd like to make it a stronger default for the regular user flow: e.g. a user that has {user_settings.project_dir} set sees Dataset name & Advanced options. They'd have to expand Advanced options to set the optional zarr_dir to something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants